Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #737 #738

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Fixes #737 #738

merged 1 commit into from
Jul 26, 2022

Conversation

jaopaulolc
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link

Hi @jaopaulolc!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2022

Codecov Report

Merging #738 (bb1557e) into development (4a9f10d) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #738      +/-   ##
===============================================
- Coverage        88.79%   88.59%   -0.21%     
===============================================
  Files              129      129              
  Lines             7854     7854              
===============================================
- Hits              6974     6958      -16     
- Misses             880      896      +16     
Impacted Files Coverage Δ
...loop_tool/service/loop_tool_compilation_session.py 87.83% <0.00%> (-2.71%) ⬇️
compiler_gym/service/connection.py 75.91% <0.00%> (-2.68%) ⬇️
compiler_gym/service/service_cache.py 89.47% <0.00%> (-2.64%) ⬇️
...ompiler_gym/service/client_service_compiler_env.py 89.80% <0.00%> (-0.64%) ⬇️

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 25, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@ChrisCummins
Copy link
Contributor

LGTM, thanks @jaopaulolc!

@ChrisCummins ChrisCummins merged commit 85430bc into facebookresearch:development Jul 26, 2022
This was referenced Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants