Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm_instcount] Leaderboard Submission: GATv2 with DD-PPO #728

Merged
merged 35 commits into from
Jul 6, 2022

Conversation

anthony0727
Copy link
Contributor

This adds entrypoint for model learnt from Programl observations.

Programl encoded with graph neural network, and align tasks in as much parallelism as possible to remove temporal correlation(just like replay buffer from Deep-Q Network). The model is optimized with PPOv2 loss.

The datasets used to train are ['cbench-v1', 'mibench-v1', 'blas-v0', 'npb-v0'] with limited node/edge counts(due to our shortage of resouce).

Anticipating better result with additional experiments(this has been halted from our internal server maintanance, and will be resumed when done).

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 29, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2022

Codecov Report

Merging #728 (70dd040) into development (3a5e439) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #728      +/-   ##
===============================================
+ Coverage        88.67%   88.73%   +0.06%     
===============================================
  Files              131      131              
  Lines             7936     7936              
===============================================
+ Hits              7037     7042       +5     
+ Misses             899      894       -5     
Impacted Files Coverage Δ
compiler_gym/service/connection.py 77.59% <0.00%> (-1.01%) ⬇️
...ompiler_gym/service/client_service_compiler_env.py 90.89% <0.00%> (+0.41%) ⬆️
...loop_tool/service/loop_tool_compilation_session.py 90.54% <0.00%> (+0.67%) ⬆️
compiler_gym/envs/llvm/datasets/cbench.py 80.57% <0.00%> (+1.07%) ⬆️
compiler_gym/views/observation.py 100.00% <0.00%> (+2.70%) ⬆️
compiler_gym/views/observation_space_spec.py 85.71% <0.00%> (+2.85%) ⬆️

@ChrisCummins
Copy link
Contributor

Hi @anthony0727, fantastic! Great to see a GNN-backed RL implementation. Couple of things:

  • Your results.csv file is missing columns. The easiest way to make sure you populate all of the columns in the right order is to use the compiler_gym.CompilerEnvStateWriter to create your CSV file.
  • There is trailing whitespace in your README.md. You can either strip that using your editor, or use our pre-commit hooks to do this automatically.

Also, be sure to add an entry to the main README.md with your entry!

BTW, the vocab file that I think you are looking for can be found here: https://zenodo.org/record/4247595

Cheers,
Chris

@anthony0727
Copy link
Contributor Author

anthony0727 commented Jun 30, 2022

Hey @ChrisCummins, resovled two bullets you told me!
Again, ghostscript was excluded in the result.csv, due to resource shortage

BTW,
Can the ranking in the main README.md be updated with new experiments? (though ranking is not about everything, I observed some better results, but it's gone with the server issue)

Thanks!
Anthony

README.md Show resolved Hide resolved
@ChrisCummins
Copy link
Contributor

Hi Anthony,

Thanks for the fixes 🙂

BTW, Can the ranking in the main README.md be updated with new experiments? (though ranking is not about everything, I observed some better results, but it's gone with the server issue)

Yes, just send us a PR when you have the new results to update your position on the leaderboard.

One small comment about changing the walltime reported for greedy search. Other than, LGTM!

Cheers,
Chris

@ChrisCummins ChrisCummins merged commit fec99d5 into facebookresearch:development Jul 6, 2022
This was referenced Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants