Example unrolling service without bazel #530
Conversation
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## development #530 +/- ##
================================================
- Coverage 87.49% 43.68% -43.81%
================================================
Files 113 113
Lines 6411 6407 -4
================================================
- Hits 5609 2799 -2810
- Misses 802 3608 +2806
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
LGTM, thanks @mostafaelhoushi!
I think the approach of adding a new build option for the examples directory makes sense to me. @sogartar, as the author of the CMake build, does that look good to you?
Could you update the CI job to build with -DCOMPILER_GYM_BUILD_EXAMPLES=on?
examples/example_unrolling_service/loop_unroller/CMakeLists.txt
Outdated
Show resolved
Hide resolved
| # In the repo's INSTALL.md, follow the 'Building from source using CMake' instructions with `-DCOMPILER_GYM_BUILD_EXAMPLES=ON` added to the `cmake` command | ||
| # Then copy the `loop_unroller` binary | ||
| $ cd <path to source directory>/examples | ||
| $ cp <path to build directory>/examples/example_unrolling_service/loop_unroller/loop_unroller ./example_unrolling_service/loop_unroller/ |
There was a problem hiding this comment.
@ChrisCummins here as a hack I am copying the executable from the build directory to next to the Python file in the source directory.
What should be the proper way of doing this? Creating a py_binary for the Python script in CMake and adding the executable as a dependency? I would prefer a way that would treat the script as a standalone.
Maybe add the path to the executable to the PATH environment variable?
There was a problem hiding this comment.
If you make a py_binary it will create a symlink in the build directory under the same subdirectory as is the source file relative to the top source directory.
Then you run the symlink.
This is generally the correct aporach.
|
@ChrisCummins, I missed your question. |
Here I build the
loop_unrollertool within the repo's CMake. Do you think it is better to have a separate/isolated build script for it?