[datasets] Make the site_data_base path optional.
#518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows datasets to be specified without needing to pass a `site_data_base` argument. The purpose of `site_data_base` to provide an on-disk cache for persistent files, but not all datasets need such a cache.
ChrisCummins
force-pushed
the
optional-dataset-site-data
branch
from
3c44827
to
b797c33
Compare
|
CC @mostafaelhoushi, this resolves one of the TODO notes in your loop environment PR |
Codecov Report
@@ Coverage Diff @@
## development #518 +/- ##
===============================================
+ Coverage 87.33% 87.36% +0.03%
===============================================
Files 113 113
Lines 6403 6411 +8
===============================================
+ Hits 5592 5601 +9
+ Misses 811 810 -1
Continue to review full report at Codecov.
|
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows datasets to be specified without needing to pass a
site_data_baseargument. The purpose ofsite_data_baseto provide an on-disk cache for persistent files, but not all datasets need such a cache.