Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] Add a new Bitcode observation space. #442

Merged
merged 3 commits into from
Sep 30, 2021

Conversation

ChrisCummins
Copy link
Contributor

This adds a Bitcode observation space that returns the bitcode of an
LLVM module directly as a byte array, without having to go via an
intermediate file.

Fixes #426.

This adds a Bitcode observation space that returns the bitcode of an
LLVM module directly as a byte array, without having to go via an
intermediate file.

Fixes facebookresearch#426.
@ChrisCummins ChrisCummins added this to the v0.2.1 milestone Sep 29, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #442 (b2dc549) into development (4ba9a7a) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #442      +/-   ##
===============================================
+ Coverage        87.36%   87.38%   +0.02%     
===============================================
  Files              104      104              
  Lines             5966     5969       +3     
===============================================
+ Hits              5212     5216       +4     
+ Misses             754      753       -1     
Impacted Files Coverage Δ
compiler_gym/spaces/sequence.py 96.96% <100.00%> (+0.30%) ⬆️
compiler_gym/views/observation.py 96.87% <0.00%> (-3.13%) ⬇️
compiler_gym/views/observation_space_spec.py 90.42% <0.00%> (-1.07%) ⬇️
compiler_gym/datasets/dataset.py 85.71% <0.00%> (-0.80%) ⬇️
compiler_gym/envs/llvm/datasets/cbench.py 78.37% <0.00%> (-0.78%) ⬇️
compiler_gym/service/connection.py 77.58% <0.00%> (+1.03%) ⬆️
compiler_gym/envs/llvm/llvm_benchmark.py 89.11% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ba9a7a...b2dc549. Read the comment docs.

Copy link
Contributor

@hughleat hughleat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :)

@ChrisCummins ChrisCummins merged commit b24a21e into facebookresearch:development Sep 30, 2021
@ChrisCummins ChrisCummins deleted the bitcode branch September 30, 2021 07:46
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this pull request Sep 30, 2021
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this pull request Sep 30, 2021
This was referenced Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observation 'Bitcode' without going through a temporary file.
4 participants