Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service] Add a reusable CompilationService runtime. #270

Merged
merged 3 commits into from
May 17, 2021

Conversation

ChrisCummins
Copy link
Contributor

This adds a new CompilerGymService class in both C++ and Python that
takes a concrete CompilationSession subclass and provides all of the
runtime logic to start and manage and RPC server that responds to
requests and dispatches to CompilationSession instances.

Issue #254.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2021

Codecov Report

Merging #270 (13c5f37) into development (8aacc9c) will decrease coverage by 1.88%.
The diff coverage is 30.82%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #270      +/-   ##
===============================================
- Coverage        83.66%   81.77%   -1.89%     
===============================================
  Files               78       81       +3     
  Lines             4426     4571     +145     
===============================================
+ Hits              3703     3738      +35     
- Misses             723      833     +110     
Impacted Files Coverage Δ
...mpiler_gym/service/runtime/compiler_gym_service.py 22.00% <22.00%> (ø)
...ice/runtime/create_and_run_compiler_gym_service.py 46.34% <46.34%> (ø)
compiler_gym/service/connection.py 73.99% <66.66%> (-2.77%) ⬇️
compiler_gym/service/runtime/__init__.py 100.00% <100.00%> (ø)
compiler_gym/envs/compiler_env.py 86.33% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aacc9c...13c5f37. Read the comment docs.

This adds a new CompilerGymService class in both C++ and Python that
takes a concrete CompilationSession subclass and provides all of the
runtime logic to start and manage and RPC server that responds to
requests and dispatches to CompilationSession instances.

Issue facebookresearch#254.
The --nproc flag is used elsewhere in the codebase.
@ChrisCummins
Copy link
Contributor Author

The reason there are no tests for the new code is because the next PR will port the existing compiler gym services to this new runtime, allowing the existing tests to cover this.

@ChrisCummins ChrisCummins merged commit 2e9a7df into facebookresearch:development May 17, 2021
@ChrisCummins ChrisCummins deleted the runtime branch May 17, 2021 18:38
This was referenced Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants