Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore "Skipping static resource" message from SW precache #2645

Merged
merged 1 commit into from
Jun 27, 2017

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Jun 27, 2017

For some reason it comes up as false positive on Uglify errors which is bad: #2433.
It is also not very meaningful to most users (skipping what? why?)

For now I'm muting it, but we can consider adding our own warnings for large bundles in the future.

@gaearon gaearon added this to the 1.0.8 milestone Jun 27, 2017
@gaearon gaearon merged commit 91064a1 into facebook:master Jun 27, 2017
gaearon added a commit that referenced this pull request Jun 27, 2017
@gaearon gaearon mentioned this pull request Jun 28, 2017
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
morgs32 pushed a commit to BrickworkSoftware/create-react-app that referenced this pull request Sep 1, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants