Extend gtest_discover_tests timeout
#1237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parallel builds can fail intermittently with the default timeout for `gtest_discover_tests`.[^1] At Homebrew, we've been using this change for a while with no problems[^2], so I hope it would be helpful to upstream it. [^1]: See https://cmake.org/cmake/help/latest/module/GoogleTest.html#command:gtest_discover_tests [^2]: Since Homebrew/homebrew-core@3e9b81f
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request has been merged in e2c94e7. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Sep 11, 2024
Summary: Parallel builds can fail intermittently with the default timeout for `gtest_discover_tests`.[^1] At Homebrew, we've been using this change for a while with no problems[^2], so I hope it would be helpful to upstream it. [^1]: See https://cmake.org/cmake/help/latest/module/GoogleTest.html#command:gtest_discover_tests [^2]: Since Homebrew/homebrew-core@3e9b81f X-link: facebook/watchman#1237 Reviewed By: genevievehelsel Differential Revision: D60670851 fbshipit-source-id: 74f542ca1c880e1d8aada10fad23e4bb6c3e142e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parallel builds can fail intermittently with the default timeout for
gtest_discover_tests.1At Homebrew, we've been using this change for a while with no problems2,
so I hope it would be helpful to upstream it.
Footnotes
See https://cmake.org/cmake/help/latest/module/GoogleTest.html#command:gtest_discover_tests ↩
Since https://github.com/Homebrew/homebrew-core/commit/3e9b81fe294535117437ec4c9f1b32b3634419bf ↩