fix: inspect ClassComponent.render instead of constructor, fixes #16749…

… (#16759)
facebook · Sep 12, 2019 · ba932a5 · ba932a5
1 parent 35a202d
commit ba932a5
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/packages/react-devtools-extensions/src/utils.js b/packages/react-devtools-extensions/src/utils.js
@@ -12,10 +12,21 @@ export function createViewElementSource(bridge: Bridge, store: Store) {
 
       setTimeout(() => {
         // Ask Chrome to display the location of the component function,
+        // or a render method if it is a Class (ideally Class instance, not type)
         // assuming the renderer found one.
         chrome.devtools.inspectedWindow.eval(`
           if (window.$type != null) {
-            inspect(window.$type);
+            if (
+              window.$type &&
+              window.$type.prototype &&
+              window.$type.prototype.isReactComponent
+            ) {
+              // inspect Component.render, not constructor
+              inspect(window.$type.prototype.render);
+            } else {
+              // inspect Functional Component
+              inspect(window.$type);
+            }
           }
         `);
       }, 100);