Skip to content

Commit

Permalink
[Fresh] Hash signatures (#16738)
Browse files Browse the repository at this point in the history
  • Loading branch information
gaearon authored Sep 10, 2019
1 parent fd3e8cb commit ba6bb0f
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 3 deletions.
17 changes: 15 additions & 2 deletions packages/react-refresh/src/ReactFreshBabelPlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

'use strict';

export default function(babel, opts) {
export default function(babel, opts = {}) {
if (typeof babel.getEnv === 'function') {
// Only available in Babel 7.
const env = babel.getEnv();
Expand Down Expand Up @@ -300,7 +300,20 @@ export default function(babel, opts) {
}
});

const args = [node, t.stringLiteral(key)];
let finalKey = key;
if (typeof require === 'function' && !opts.emitFullSignatures) {
// Prefer to hash when we can (e.g. outside of ASTExplorer).
// This makes it deterministically compact, even if there's
// e.g. a useState ininitalizer with some code inside.
// We also need it for www that has transforms like cx()
// that don't understand if something is part of a string.
finalKey = require('crypto')
.createHash('sha1')
.update(key)
.digest('base64');
}

const args = [node, t.stringLiteral(finalKey)];
if (forceReset || customHooksInScope.length > 0) {
args.push(t.booleanLiteral(forceReset));
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,14 @@ function transform(input, options = {}) {
plugins: [
'@babel/syntax-jsx',
'@babel/syntax-dynamic-import',
[freshPlugin, {skipEnvCheck: true}],
[
freshPlugin,
{
skipEnvCheck: true,
// To simplify debugging tests:
emitFullSignatures: true,
},
],
...(options.plugins || []),
],
}).code,
Expand Down

0 comments on commit ba6bb0f

Please sign in to comment.