Update ScrollResponder.js to use new scrollTo API
#5990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is one non-deprecated method (`scrollResponderInputMeasureAndScrollToKeyboard`) that doesn't use the new `scrollTo` API. This commit squashes the warning.
|
By analyzing the blame information on this pull request, we identified @ericvicenti, @sahrens and @nicklockwood to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
@facebook-github-bot shipit |
|
I just approved a duplicate #6012. |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
mkonicek
pushed a commit
that referenced
this pull request
Mar 1, 2016
Summary:`scrollResponderInputMeasureAndScrollToKeyboard` is the only non-deprecated method in `ScrollResponder.js` that doesn't use the [new `scrollTo` API](6941c4e). The other method that uses the deprecated API (`scrollResponderScrollWithoutAnimationTo`) is also deprecated, so it has been left unaltered. Closes #5990 Differential Revision: D2953916 Pulled By: nicklockwood fb-gh-sync-id: d692c598e6b85d1050e58b87146d01b031653a49 shipit-source-id: d692c598e6b85d1050e58b87146d01b031653a49
pglotov
pushed a commit
to pglotov/react-native
that referenced
this pull request
Mar 15, 2016
Summary:`scrollResponderInputMeasureAndScrollToKeyboard` is the only non-deprecated method in `ScrollResponder.js` that doesn't use the [new `scrollTo` API](facebook@6941c4e). The other method that uses the deprecated API (`scrollResponderScrollWithoutAnimationTo`) is also deprecated, so it has been left unaltered. Closes facebook#5990 Differential Revision: D2953916 Pulled By: nicklockwood fb-gh-sync-id: d692c598e6b85d1050e58b87146d01b031653a49 shipit-source-id: d692c598e6b85d1050e58b87146d01b031653a49
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scrollResponderInputMeasureAndScrollToKeyboardis the only non-deprecated method inScrollResponder.jsthat doesn't use the newscrollToAPI. The other method that uses the deprecated API (scrollResponderScrollWithoutAnimationTo) is also deprecated, so it has been left unaltered.