Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example implementation for Android <Portal> per #2501 #5264

Closed
wants to merge 1 commit into from
Closed

Added example implementation for Android <Portal> per #2501 #5264

wants to merge 1 commit into from

Conversation

niftylettuce
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @vjeux, @mkonicek and @brentvatne to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jan 12, 2016
@mkonicek
Copy link
Contributor

We've been discussing whether to keep the portal implementation or ship a native module for showing modals instead.

In the Ads Manager we currently use the Portal to implement modals (https://gist.github.com/mkonicek/1a45b8f8c36bb710478c) but might deprecate that actually.

Would you mind holding with this until it's clear whether we'll go with the native module?

@niftylettuce
Copy link
Contributor Author

@mkonicek are you asking me? I think this should be accepted as a PR or a decision should be made ASAP, there needs to be native modal support on Android.

@mkonicek
Copy link
Contributor

The decision is we'd like to go with the native module to implement Modal on Android, there's the PR #5320 but still need to figure out touch handling.

I agree we should clear out the list of missing Android modules as quickly as we can: https://facebook.github.io/react-native/docs/known-issues.html, a few releases from now it should be gone except for push notifications for which we only have an implementation very tied to the fb infra and using it in the Ads Manager on Android.

@facebook-github-bot
Copy link
Contributor

@niftylettuce updated the pull request.

@satya164
Copy link
Contributor

@mkonicek We should probably document since Modal is not going to be ready anytime soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants