Change the signature of onDropViewInstance. issue #5053 #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @mkonicek, @kmagiera and @andreicoman11 to be potential reviewers. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
Thanks for the PR! However, now that I think about it, it doesn't make a lot of sense to pass the context at all, since we're passing the view and that will always have a reference to it. Can you remove the context parameter completely? |
|
@deminoth updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
@foghina You're right. I'm a newbie at the android programming so I didn't noticed that. |
|
Thanks, this looks good! @facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/108659042846099/int_phab to review. |
ghost
closed this
in
christopherdro
pushed a commit
to wildlifela/react-native
that referenced
this pull request
Jan 20, 2016
Summary: facebook#5053 Closes facebook#5125 Reviewed By: svcscm Differential Revision: D2807202 Pulled By: foghina fb-gh-sync-id: 1e268c940a08aa7bf243971ba91d4595973f12af
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5053