Infinite recursion in RCTFatal when the bundle fails to execute #5090

ide · 2016-01-03T09:06:08Z

RCTFatal calls _RCTLogNativeInternal which enqueues a JS call. This can fail because a previous RCTFatal occurred because the bundle failed to execute in the first place. So when RCTFatal fails, it ends up calling RCTFatal again in an infinite loop.

cc @javache

javache · 2016-01-05T23:30:43Z

I believe I fixed this in 0cfe763

If an error happens as part of bridge init, the JS executor is invalidated and will no longer enqueue the JS call.

skevy · 2016-01-05T23:33:50Z

@javache I encountered this error on master about 3 days ago, fyi.

philikon · 2016-01-08T06:12:21Z

I don't believe 0cfe763 fixed this because the bug is present in 0.18.0rc.

javache · 2016-01-08T10:27:47Z

@philikon Can you provide an example of how to reproduce this? If something as fundamental as __fbBatchedBridge is broken, it should be caught during startup and cause the bridge to be invalidated.

Either way, this bug should only be present when debugging using the Chrome executor.

jvliwanag · 2016-01-08T10:36:38Z

Using a new 0.18.0rc project. Replace the contents of index.ios.js with:

asdfasdf

Doesn't need to run on chrome executor.

yueshuaijie · 2016-01-09T01:02:13Z

I encountered this error, too. Hope to find a solution.

philikon · 2016-01-09T01:45:17Z

@javache I get this if the package server isn't reachable / running for the app.

#4739 seems related.

Creemli · 2016-01-12T14:50:19Z

I also see this error when i use 0.18.0-rc with bundled js.

Purii · 2016-01-12T15:26:13Z

Me too @Creemli
I get this error only, when I use bundled js.

stereodenis · 2016-01-12T15:35:23Z

waiting for fix too

Creemli · 2016-01-13T08:44:27Z

@Purii I fixed this issue by copying the code from http://localhost:8081/index.ios.bundle to main.jsbundle. And it works well~~~

Purii · 2016-01-14T18:32:59Z

@Creemli doesn't work for me. Neither with dev=false nor dev=true

Mokto · 2016-01-14T19:23:18Z

I also got this error.

javache · 2016-01-15T12:33:16Z

This is now failing recursively because we check more carefully for an invalid bundle (5b4e873). I'm looking to see if there's any way we can bail out earlier in this case without breaking other debug tools.

Purii · 2016-01-15T13:39:53Z

@javache

check more carefully for an invalid bundle

Does this mean, that there is something wrong with our code, or is it the packager which fails?

javache · 2016-01-15T13:42:48Z

@Purii: yes, please verify that the bundle you're trying to load in the packager is valid.

Purii · 2016-01-16T01:33:29Z

@javache Running eslint on the bundle throws the following errors:

"babelHelpers" is not defined
"__d" is not defined
"__BUNDLE_START_TIME__" is not defined
"self" is not defined
"__REACT_DEVTOOLS_GLOBAL_HOOK__" is not defined
"GLOBAL" is not defined
"window" is read only
"MessageChannel" is not defined
"FileReader" is not defined
"Blob" is not defined
"FormData" is not defined
"Node" is not defined
"math" is not defined
"regeneratorRuntime" is not defined

The list looks similar on a new project with 0.17.0.
Checking my source files via eslint doesn't throw any error.

dsernst · 2016-01-17T04:14:42Z

Seeing this after following the standard instructions from https://facebook.github.io/react-native/docs/getting-started.html#quick-start

Purii · 2016-01-18T22:08:57Z

Seems to be fixed with 0.18.0-final.

danscan · 2016-01-19T15:41:33Z

I'm seeing this issue after upgrading a project from 0.15 to 0.18. I used react-native upgrade, and updated deps that can now depend on react.

jasonmerino · 2016-01-19T19:30:25Z

I'm seeing this issue after trying to upgrade from 0.16 to 0.18. I also used react-native upgrade.

Summary: This solves #5090. Since 5b4e873 we had better reporting for when calls from native to JS fail. When trying to load an invalid bundle, this would now cause a stackoverflow, since RCTFatal would schedule a JS call to log, which would RCTFatal, which would ... By invalidating the jsExecutor immediately after loading fails, we prevent any more attempts to log. We can't invalidate the whole bridge at this point since we still need the redbox module to actually display the error. public Reviewed By: majak Differential Revision: D2834251 fb-gh-sync-id: a3e2ad425e40560beae4d3eacb93f66ace5341bf

yueshuaijie · 2016-01-20T03:17:41Z

I'm seeing this issue in 0.18.0-rc, after upgrade to 0.18.0, it disappeared.

Summary: This solves #5090. Since 5b4e873 we had better reporting for when calls from native to JS fail. When trying to load an invalid bundle, this would now cause a stackoverflow, since RCTFatal would schedule a JS call to log, which would RCTFatal, which would ... By invalidating the jsExecutor immediately after loading fails, we prevent any more attempts to log. We can't invalidate the whole bridge at this point since we still need the redbox module to actually display the error. public Reviewed By: majak Differential Revision: D2834251 fb-gh-sync-id: a3e2ad425e40560beae4d3eacb93f66ace5341bf

mkonicek · 2016-01-20T14:12:37Z

@javache tells me this one should help too: 8ea9a1b, just released 0.18.1 with that commit. Give it a try.

No need to react-native upgrade, simply update the version in package.json. It's an iOS only change, we introduced the upgrade command mostly because of Android.

Summary: This solves facebook#5090. Since facebook@5b4e873 we had better reporting for when calls from native to JS fail. When trying to load an invalid bundle, this would now cause a stackoverflow, since RCTFatal would schedule a JS call to log, which would RCTFatal, which would ... By invalidating the jsExecutor immediately after loading fails, we prevent any more attempts to log. We can't invalidate the whole bridge at this point since we still need the redbox module to actually display the error. public Reviewed By: majak Differential Revision: D2834251 fb-gh-sync-id: a3e2ad425e40560beae4d3eacb93f66ace5341bf

23c · 2016-01-24T02:16:37Z

I downgrade to 0.16.0 version, over this problem.

mkonicek · 2016-01-25T00:17:15Z

8ea9a1b released with 0.18.1 should be the fix. Let's close this and reopen if it still appears in 0.18.1 and later versions.

mixophrygian · 2016-01-25T00:41:05Z

just encountered this in 0.18.0 - somehow ReactLog.m was getting a new line (\n) prepended to the top of the file. Problem went away when it was removed.

dvcrn · 2016-01-25T10:48:24Z

Just encountered this with 0.18.1. Didn't have it in 0.18-rc but since the update this is appearing for me as well

leeabc · 2016-01-25T16:42:55Z

Still get this issue in 0.18.1

Step:

npm install --save react-native@0.18
react-native upgrade
run in xcode

[error][tid:com.facebook.React.JavaScript] Unable to execute JS call: __fbBatchedBridge is undefined

Could someone can help on this case ?

javache · 2016-01-25T16:46:50Z

That means something went wrong with loading/executing your JS bundle. This task only concerns infinite recursion happening as a side-effect of that. Please open a new issue instead.

DickyT · 2016-01-28T06:18:31Z

also got this issue sometimes, using bundled js without dev mode in 0.19-rc

stereodenis · 2016-02-03T16:37:15Z

@javache got this issue with 0.19
I think react-native-xcode.sh is not packing main.jsbundle

ide · 2016-02-03T22:32:00Z

@stereodenis are you experiencing infinite recursion or seeing __fbBatchedBridge is undefined?

shohey1226 · 2016-02-03T23:26:13Z

I saw this with 0.19 when I tried to run on device after upgraded from 0.13. I checked in the log and realized that react-native-xcode.sh is just missing.. needed to do work on https://facebook.github.io/react-native/docs/upgrading.html#manual-upgrades

stereodenis · 2016-02-04T08:20:22Z

@ide __fbBatchedBridge is undefined

javache · 2016-02-04T17:58:02Z

Please file a new issue when you're just seeing this error. __fbBatchedBridge is undefined points at issues with the JS bundle setup. Since the infinite recursion here has been resolved, I'm locking this issue.

ide added the Platform: iOS iOS applications. label Jan 3, 2016

javache self-assigned this Jan 15, 2016

mkonicek closed this as completed Jan 25, 2016

facebook locked and limited conversation to collaborators Feb 4, 2016

react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 20, 2018

Infinite recursion in RCTFatal when the bundle fails to execute #5090

Infinite recursion in RCTFatal when the bundle fails to execute #5090

Comments

ide commented Jan 3, 2016

javache commented Jan 5, 2016

skevy commented Jan 5, 2016

philikon commented Jan 8, 2016

javache commented Jan 8, 2016

jvliwanag commented Jan 8, 2016

yueshuaijie commented Jan 9, 2016

philikon commented Jan 9, 2016

Creemli commented Jan 12, 2016

Purii commented Jan 12, 2016

stereodenis commented Jan 12, 2016

Creemli commented Jan 13, 2016

Purii commented Jan 14, 2016

Mokto commented Jan 14, 2016

javache commented Jan 15, 2016

Purii commented Jan 15, 2016

javache commented Jan 15, 2016

Purii commented Jan 16, 2016

dsernst commented Jan 17, 2016

Purii commented Jan 18, 2016

danscan commented Jan 19, 2016

jasonmerino commented Jan 19, 2016

yueshuaijie commented Jan 20, 2016

mkonicek commented Jan 20, 2016

23c commented Jan 24, 2016

mkonicek commented Jan 25, 2016

mixophrygian commented Jan 25, 2016

dvcrn commented Jan 25, 2016

leeabc commented Jan 25, 2016

javache commented Jan 25, 2016

DickyT commented Jan 28, 2016

stereodenis commented Feb 3, 2016

ide commented Feb 3, 2016

shohey1226 commented Feb 3, 2016

stereodenis commented Feb 4, 2016

javache commented Feb 4, 2016