Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flipper Android 0.71 #35834

Closed
billnbell opened this issue Jan 15, 2023 · 14 comments
Closed

Flipper Android 0.71 #35834

billnbell opened this issue Jan 15, 2023 · 14 comments
Labels
Needs: Attention Issues where the author has responded to feedback. Needs: Issue Template This issue does not make use of the Issue Template, and may be missing necessary information. Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Needs: Triage 🔍 Platform: Android Android applications. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@billnbell
Copy link
Contributor

billnbell commented Jan 15, 2023

Description

FLIPPER_VERSION=0.176.1

I am getting null in Debug mode and addPlugin fails. Why?

Also we should add a check for null.

 public static void initializeFlipper(Context context, ReactInstanceManager reactInstanceManager) {
    if (FlipperUtils.shouldEnableFlipper(context)) {
      final FlipperClient client = AndroidFlipperClient.getInstance(context);
      if (client == null) {
        return;
      }

But I have flipper running in desktop and I keep getting null. How do I figure out the issue?

Version

0.71

Output of npx react-native info

None

Steps to reproduce

None

Snack, code example, screenshot, or link to a repository

None

@togenius1
Copy link

same error

@billnbell
Copy link
Contributor Author

??? This seems like a big issue.

@billnbell
Copy link
Contributor Author

Do we need to install react-native-flipper ? I don't see anything about that in the docs?

@kelset kelset added Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Needs: Issue Template This issue does not make use of the Issue Template, and may be missing necessary information. labels Jan 17, 2023
@github-actions
Copy link

⚠️ Missing Required Fields
ℹ️ It looks like your issue may be missing some necessary information. GitHub provides an example template whenever a new issue is created. Could you go back and make sure to fill out the template? You may edit this issue, or close it and open a new one.

@github-actions
Copy link

⚠️ Missing Reproducible Example
ℹ️ It looks like your issue is missing a reproducible example. Please provide a Snack or a repository that demonstrates the issue you are reporting in a minimal, complete, and reproducible manner.

@cortinico
Copy link
Contributor

I am getting null in Debug mode and addPlugin fails. Why?

Can you clarify what's your issue more exactly?
Where are you getting null?
Is Flipper workign fine on a empty project, without bumping to 0.176.1?

Do we need to install react-native-flipper ? I don't see anything about that in the docs?

Nope you don't need to install react-native-flipper

@billnbell
Copy link
Contributor Author

I put the fix in above. The client returns null for me.

final FlipperClient client = AndroidFlipperClient.getInstance(context);

This is null!

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels Jan 18, 2023
@cortinico
Copy link
Contributor

Is Flipper workign fine on a empty project, without bumping to 0.176.1?

@cortinico cortinico added Needs: Author Feedback and removed Needs: Attention Issues where the author has responded to feedback. labels Jan 18, 2023
@billnbell
Copy link
Contributor Author

I cannot get it to work at all. 0.125 or 0.176 both do not work for me. Yea I did clean and run rm Podfile.lock && pod deintegrate && pod install between runs... any ideas?

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels Jan 18, 2023
@cortinico
Copy link
Contributor

Yea I did clean and run rm Podfile.lock && pod deintegrate && pod install between runs... any ideas?

Initially you mentioned this is an Android issue. Here you mention pod install so it's unclear to me what's the issue you're having. Is it Android or iOS?

@billnbell
Copy link
Contributor Author

you are right. I am losing my mind. It is 100% Android.

I am trying 0.176 - how do I make sure that is set for Android

@cortinico
Copy link
Contributor

I am trying 0.176 - how do I make sure that is set for Android

My question was if the issue is happening on version 0.125.0 (the version shipped with RN 0.71).

@github-actions
Copy link

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Jul 19, 2023
@github-actions
Copy link

This issue was closed because it has been stalled for 7 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Attention Issues where the author has responded to feedback. Needs: Issue Template This issue does not make use of the Issue Template, and may be missing necessary information. Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Needs: Triage 🔍 Platform: Android Android applications. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

5 participants