-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promise returned by share dialog won't resolve if cancelled on iOS #26809
Comments
To add more info to this. I believe the bug might be here: https://github.com/facebook/react-native/blob/master/React/CoreModules/RCTActionSheetManager.mm#L183 Changing the Opened a PR addressing this issue. |
@v-fernandez, do you know when this fix will be available, if it's not already? |
@cdunkel I'm not sure when this will be available, but in the meantime, you can use patch-package to make the fix available for you in the version you are using. |
Why is the fix still not merged? I still encounter this issue in 0.61.5 |
@metawort this will be available on v0.62.0. See #26842 (comment) |
On iOS, the share text dialog won't resolve the returned promise when the dialog is dismissed by pressing the Cancel button or by pressing outside the dialog. Other share options resolve the promise as expected.
React Native version: 0.61.2
Steps To Reproduce
Share.share(content, options)
Describe what you expected to happen: The promise returned by
Share.share(content, options)
should be resolved when the dialog is dismissed.Snack, code example, screenshot, or link to a repository:
The text was updated successfully, but these errors were encountered: