Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIScrollView decelerationRate default should be 'normal' instead of 'fast' #22900

Closed
petekp opened this issue Jan 7, 2019 · 3 comments
Closed
Labels
Bug Component: ScrollView Resolution: Locked This issue was locked by the bot.

Comments

@petekp
Copy link

petekp commented Jan 7, 2019

Environment

React Native Environment Info:
    System:
      OS: macOS 10.14
      CPU: (12) x64 Intel(R) Core(TM) i9-8950HK CPU @ 2.90GHz
      Memory: 6.41 GB / 32.00 GB
      Shell: 2.7.1 - /usr/local/bin/fish
    Binaries:
      Node: 8.9.4 - ~/.nvm/versions/node/v8.9.4/bin/node
      Yarn: 1.12.3 - ~/.yarn/bin/yarn
      npm: 5.6.0 - ~/.nvm/versions/node/v8.9.4/bin/npm
    SDKs:
      iOS SDK:
        Platforms: iOS 12.0, macOS 10.14, tvOS 12.0, watchOS 5.0
    IDEs:
      Android Studio: 3.2 AI-181.5540.7.32.5056338
      Xcode: 10.0/10L213o - /usr/bin/xcodebuild
    npmPackages:
      react: 16.6.3 => 16.6.3
      react-native: 0.57.7 => 0.57.7

Description

The default scrollview deceleration rate for the WebView in iOS was changed from 'fast' to 'normal' in iOS 11 (prompted by the emergence of Google AMP-powered sites which used a workaround to enable 'normal' deceleration to make scrolling feel more native), but React Native still defaults to 'fast', which is the higher-friction, less native feeling deceleration.

See UIScrollViewDecelerationRate docs and webkit changelog. More info on this history of this change: https://www.macobserver.com/analysis/apple-plans-change-scrolling-safari/

Happy to submit a PR to update this if it's a welcome change.

@ericlewis
Copy link
Contributor

The new repo for webview is over here: https://github.com/react-native-community/react-native-webview

@petekp
Copy link
Author

petekp commented Mar 1, 2019

@ericlewis Thanks! I suspected this may be an upstream issue in the RN ScrollView component? Could be wrong — will take a closer look :)

@Titozzz
Copy link
Collaborator

Titozzz commented Mar 19, 2019

I'll close the issue here but feel free to submit a PR to either webview in its own repo or scrollView. (I think we should match apple when deciding where to apply the patch)

@Titozzz Titozzz closed this as completed Mar 19, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Mar 19, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Mar 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Component: ScrollView Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants