Skip to content

Commit

Permalink
Add GuardedResultAsyncTask
Browse files Browse the repository at this point in the history
Reviewed By: andreicoman11

Differential Revision: D2679459

fb-gh-sync-id: 8a9ec170ce76bbc3340c9e8872e19b78ae5a5c2d
  • Loading branch information
lexs authored and facebook-github-bot-6 committed Nov 23, 2015
1 parent 5447002 commit f57c2a9
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,8 @@
* handled by the {@link com.facebook.react.bridge.NativeModuleCallExceptionHandler} registered if
* the app is in dev mode.
*
* This class doesn't allow doInBackground to return a results. This is mostly because when this
* class was written that functionality wasn't used and it would require some extra code to make
* work correctly with caught exceptions. Don't let that stop you from adding it if you need it :)
* This class doesn't allow doInBackground to return a results. If you need this
* use GuardedResultAsyncTask instead.
*/
public abstract class GuardedAsyncTask<Params, Progress>
extends AsyncTask<Params, Progress, Void> {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
// Copyright 2004-present Facebook. All Rights Reserved.

package com.facebook.react.bridge;

import android.os.AsyncTask;

/**
* Abstract base for a AsyncTask with result support that should have any RuntimeExceptions it
* throws handled by the {@link com.facebook.react.bridge.NativeModuleCallExceptionHandler}
* registered if the app is in dev mode.
*/
public abstract class GuardedResultAsyncTask<Result>
extends AsyncTask<Void, Void, Result> {

private final ReactContext mReactContext;

protected GuardedResultAsyncTask(ReactContext reactContext) {
mReactContext = reactContext;
}

@Override
protected final Result doInBackground(Void... params) {
try {
return doInBackgroundGuarded();
} catch (RuntimeException e) {
mReactContext.handleException(e);
throw e;
}
}

@Override
protected final void onPostExecute(Result result) {
try {
onPostExecuteGuarded(result);
} catch (RuntimeException e) {
mReactContext.handleException(e);
}
}

protected abstract Result doInBackgroundGuarded();
protected abstract void onPostExecuteGuarded(Result result);

}

0 comments on commit f57c2a9

Please sign in to comment.