Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated Testing Frameworks guide with React; make it generic #9106

Merged
merged 4 commits into from
May 3, 2020

Conversation

ms314006
Copy link
Contributor

Summary

Test plan

@facebook-github-bot
Copy link
Contributor

Hi ms314006! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #9106 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9106   +/-   ##
=======================================
  Coverage   64.73%   64.73%           
=======================================
  Files         277      277           
  Lines       11707    11707           
  Branches     2874     2874           
=======================================
  Hits         7578     7578           
  Misses       3512     3512           
  Partials      617      617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc2c92b...501ba7a. Read the comment docs.

@jeysal
Copy link
Contributor

jeysal commented Nov 6, 2019

Thanks! The paragraph at the top of that page still says that Jest may be considered React-specific, and that the page only lists other frameworks, which conflicts with your changes. But I think the top paragraph is not appropriate anymore.
Wdyt about changing that to a generic "here's some guides on how to use Jest with various web frameworks" and then just putting React there as the first framework in the list?

@thymikee thymikee changed the title Add Jest work with "testing-library/react" to Framework Guides docs: Updated Testing Frameworks guide with React; make it generic May 3, 2020
Copy link
Collaborator

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the guide to be more generic and used a link to a specific example of using RTL with Jest

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants