Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jest-jasmine2: fix describe return value warning being shown if describe throws #8335

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

jeysal
Copy link
Contributor

@jeysal jeysal commented Apr 15, 2019

Summary

Fixes the describe warning part of #8334 (intentionally not marking this as closing the whole issue)

Test plan

Added e2e test case that fails with master build (the stdout toBe('') check).

@jeysal jeysal changed the title fix describe return value warning being shown if describe throws jest-jasmine2: fix describe return value warning being shown if describe throws Apr 15, 2019
@jeysal jeysal requested review from SimenB and thymikee April 15, 2019 21:52
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants