Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to spawn command in a shell #5340

Merged
merged 6 commits into from
Jan 18, 2018
Merged

Add an option to spawn command in a shell #5340

merged 6 commits into from
Jan 18, 2018

Conversation

seanpoulter
Copy link
Contributor

Summary
This adds the option to spawn a Jest command in a shell from jest-editor-support. On Windows, using the shell option will handle adding the .cmd and .bat extensions to the pathToJest.

The issue is discussed in jest-community/vscode-jest#98.

Test plan
Unit tests have been added.

@seanpoulter
Copy link
Contributor Author

Not sure what's up with Circle CI. The "restoring cache" step is failing:

Unarchiving cache...
tar: root/jest/node_modules: Cannot mkdir: Permission denied
tar: root/jest/node_modules/.bin: Cannot mkdir: Permission denied
tar: root/jest/node_modules/.bin/JSONStream: Cannot open: Permission denied

I've tried amending the last commit, popping a commit off the branch and re-committing fresh, and I'm not having any luck. 😭

@cpojer cpojer merged commit 06bbe2d into jestjs:master Jan 18, 2018
SimenB pushed a commit that referenced this pull request Jan 18, 2018
@seanpoulter seanpoulter deleted the spawn-in-shell branch January 18, 2018 21:37
@stephtr
Copy link
Contributor

stephtr commented Feb 3, 2018

Shouldn't index.d.ts contain an updated Options definition?

) => ChildProcess,
testNamePattern?: string,
testFileNamePattern?: string,
shell?: boolean,
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants