Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "verbose" no test found message when there is only one project #4378

Merged
merged 1 commit into from
Aug 27, 2017

Conversation

rogeliog
Copy link
Contributor

@rogeliog rogeliog commented Aug 27, 2017

Summary

#4354 Did a great job on providing a better "no test found" message for MPR.

I feel that we should show the "verbose" message when there is only one project or when the user is not trying to specify a project at all.

Test plan

Before

screen shot 2017-08-27 at 1 28 11 pm

After

screen shot 2017-08-27 at 1 28 22 pm

@cpojer cpojer merged commit e5fd773 into jestjs:master Aug 27, 2017
@cpojer
Copy link
Member

cpojer commented Aug 27, 2017

Oh yeah, that makes sense :) 90% of people are running into this use case, so showing more information by default is good.

@codecov-io
Copy link

Codecov Report

Merging #4378 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4378   +/-   ##
======================================
  Coverage    56.2%   56.2%           
======================================
  Files         191     191           
  Lines        6421    6421           
  Branches        6       6           
======================================
  Hits         3609    3609           
  Misses       2809    2809           
  Partials        3       3
Impacted Files Coverage Δ
packages/jest-cli/src/get_no_test_found_message.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3ed980...a8baf62. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants