Make jest-runner a standalone package. #4236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjesun
reviewed
Aug 10, 2017
| @@ -18,14 +18,16 @@ import type { | |||
| TestResult, | |||
| } from 'types/TestResult'; | |||
| import type Runtime from 'jest-runtime'; | |||
| import type TestWatcher from 'jest-cli/src/test_watcher'; | |||
| import type {TestWatcher as _TestWatcher} from 'jest-cli'; | |||
There was a problem hiding this comment.
Can't we just keep it with the standard name? I don't see any place where it could collide.
There was a problem hiding this comment.
It's required in this file to be exported under the same name, that way I get around making jest-runner depend on jest-cli, which would be a circular dependency just to include the type information. export type TestWatcher = TestWatcher doesn't work in Flow.
mjesun
approved these changes
Aug 10, 2017
tushardhole
pushed a commit
to tushardhole/jest
that referenced
this pull request
Aug 21, 2017
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This diff splits
TestRunner,runTestandTestWorkerinto a separate package calledjest-runner. As part of this separation, a few console related modules were moved tojest-util, where other console parts were already located. This diff has no functional changes.Test plan
jest