Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-fail if hasteImpl is throwing an error during initialization. #3812

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented Jun 13, 2017

Summary

Internally at Facebook, this created tons of issues with flaky caches.

Test plan

When passing a broken hasteImpl that throws, it will now crash the workers and refuse to do its work.

@codecov-io
Copy link

Codecov Report

Merging #3812 into master will not change coverage.
The diff coverage is 83.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3812   +/-   ##
=======================================
  Coverage   57.64%   57.64%           
=======================================
  Files         194      194           
  Lines        6780     6780           
  Branches        6        6           
=======================================
  Hits         3908     3908           
  Misses       2869     2869           
  Partials        3        3
Impacted Files Coverage Δ
packages/jest-haste-map/src/worker.js 93.75% <83.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c94c23...35c2743. Read the comment docs.

@cpojer cpojer merged commit 89c5065 into jestjs:master Jun 13, 2017
@jeanlauliac
Copy link
Contributor

jeanlauliac commented Jun 14, 2017

Note this doesn't fix the core of the problem, that is, errors being indiscriminately and silently swallowed by the call site itself. This must be fixed as well, I think. I'll send a PR.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants