Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear CRA users don't need to add dependencies #3312

Merged
merged 1 commit into from
Apr 18, 2017

Conversation

gaearon
Copy link
Contributor

@gaearon gaearon commented Apr 18, 2017

I’ve seen a few people installing Jest on top of Create React App. This intro paragraph is easy to miss, and since we link to this tutorial from the React website, people try following these steps. Adding explicit headers might help here.

@codecov-io
Copy link

Codecov Report

Merging #3312 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3312   +/-   ##
=======================================
  Coverage   65.02%   65.02%           
=======================================
  Files         177      177           
  Lines        6510     6510           
  Branches        4        4           
=======================================
  Hits         4233     4233           
  Misses       2276     2276           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 890ac11...732a399. Read the comment docs.

@cpojer cpojer merged commit 4fd9e48 into master Apr 18, 2017
@gaearon gaearon deleted the gaearon-patch-1 branch April 18, 2017 15:40
skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants