Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-snapshot] Normalize line endings in serialize function #3002

Merged
merged 1 commit into from
Feb 27, 2017

Conversation

wyze
Copy link
Contributor

@wyze wyze commented Feb 25, 2017

Summary

This fixes #2969. When snapshot data is saved, it normalizes \r\n to \n, but on next runs when it receives the new snapshot data and serializes it, this normalization doesn't happen, so tests would fail without any changes to the data being snapshot tested.

Test plan

All tests pass and subsequent runs of snapshot tests containing \r\n will not fail without changes.

@cpojer cpojer merged commit 1567c02 into jestjs:master Feb 27, 2017
@wyze wyze deleted the fix-issue-2969 branch February 27, 2017 03:02
skovhus pushed a commit to skovhus/jest that referenced this pull request Apr 29, 2017
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Having a \r in the snapshot output always fails
3 participants