fix(pretty-format): Handle empty string children in React same as react-test-renderer
#14470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
SimenB
commented
Sep 5, 2023
| @@ -21,7 +21,7 @@ const getChildren = (arg: unknown, children: Array<unknown> = []) => { | |||
| arg.forEach(item => { | |||
| getChildren(item, children); | |||
| }); | |||
| } else if (arg != null && arg !== false) { | |||
| } else if (arg != null && arg !== false && arg !== '') { | |||
There was a problem hiding this comment.
this is the breaking change
SimenB
commented
Sep 5, 2023
| assertPrintedJSX( | ||
| React.createElement('Mouse', null, ''), | ||
| '<Mouse>\n \n</Mouse>', | ||
| ); | ||
| assertPrintedJSX(React.createElement('Mouse', null, ''), '<Mouse />'); |
There was a problem hiding this comment.
this shows the change that will show up in people's snapshots
This was referenced Sep 6, 2023
…act-test-renderer`
SimenB
force-pushed
the
align-pretty-format-and-test-renderer-single-string-child
branch
from
6350ca8
to
f0fefae
Compare
SimenB
deleted the
align-pretty-format-and-test-renderer-single-string-child
branch
|
I missed this made the tests time out on circle ci... 1a96a5c fixes it |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I tried to upgrade the entire repo to React 18 (for #14463), and it turns out
react-test-renderer@18has a change in how it handles empty string children. Which is fine, but aligning is a breaking change in Jest.Test plan
Adjusted the test