Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@jest/types): replace constrain with default type in one of each overrides #12905

Merged
merged 3 commits into from
Jun 5, 2022
Merged

fix(@jest/types): replace constrain with default type in one of each overrides #12905

merged 3 commits into from
Jun 5, 2022

Conversation

mrazauskas
Copy link
Contributor

Following up #12902

Summary

Feels like ESLint is right – I this case default type is better idea than a constrain, which actually does not constrain anything. Also nice to have eslint-disable line less.

Test plan

Same type tests should pass.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SimenB SimenB merged commit c4a01bd into jestjs:main Jun 5, 2022
@mrazauskas mrazauskas deleted the fix-each-types branch June 5, 2022 09:59
@github-actions
Copy link

github-actions bot commented Jul 6, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants