Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix anchor link #7813

Merged
merged 2 commits into from
Jul 20, 2022
Merged

docs: fix anchor link #7813

merged 2 commits into from
Jul 20, 2022

Conversation

andrewnicols
Copy link
Contributor

@andrewnicols andrewnicols commented Jul 20, 2022 •
edited
Loading

The link to the public API surface had an erroneous extra # in the link
preventing it from linking correctly.

Pre-flight checklist

  • [/] I have read the Contributing Guidelines on pull requests.
  • [/] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • [/] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Fix a bug in the docs

Test Plan

View /community/release-process#major-versions and attempt to follow the link in the first admonition to the "Public API surface"

Test links

Related issues/PRs

None

@andrewnicols
docs: Correct link to document section
907fec2 
The link to the public API surface had an erroneous extra # in the link
preventing it from linking correctly.
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 20, 2022
@Josh-Cena Josh-Cena changed the title docs: Correct link to document section docs: fix anchor link Jul 20, 2022
@Josh-Cena Josh-Cena added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label Jul 20, 2022
@netlify
Copy link

netlify bot commented Jul 20, 2022 •
edited
Loading

✅ [V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 0ae4373
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62d7f1fb1bf91000085c37ae
😎 Deploy Preview https://deploy-preview-7813--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jul 20, 2022 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 91 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 84 🟢 100 🟢 100 🟢 100 🟢 90 Report

Josh-Cena
Josh-Cena approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Josh-Cena Josh-Cena merged commit 7489f87 into facebook:main Jul 20, 2022
dpang314 pushed a commit to dpang314/docusaurus that referenced this pull request Jul 24, 2022
@andrewnicols @Josh-Cena @dpang314
docs: fix anchor link (facebook#7813)
59dd1b3 
* docs: Correct link to document section

The link to the public API surface had an erroneous extra # in the link
preventing it from linking correctly.

* fix prettier

Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@slorber slorber Awaiting requested review from slorber slorber is a code owner

@lex111 lex111 Awaiting requested review from lex111

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewnicols @Josh-Cena @facebook-github-bot