Fix lint

packages/docusaurus-logger/src/__tests__/index.test.ts

@@ -150,12 +150,12 @@ describe('report', () => {
     ).toThrowErrorMatchingInlineSnapshot(
       `"Unexpected "reportingSeverity" value: foo."`,
     );
-    expect(consoleLog).toBeCalledTimes(1);
-    expect(consoleLog).toBeCalledWith(
+    expect(consoleLog).toHaveBeenCalledTimes(1);
+    expect(consoleLog).toHaveBeenCalledWith(
       expect.stringMatching(/.*\[INFO\].* hey/),
     );
-    expect(consoleWarn).toBeCalledTimes(1);
-    expect(consoleWarn).toBeCalledWith(
+    expect(consoleWarn).toHaveBeenCalledTimes(1);
+    expect(consoleWarn).toHaveBeenCalledWith(
       expect.stringMatching(/.*\[WARNING\].* hey/),
     );
   });

packages/docusaurus-mdx-loader/src/remark/transformImage/__tests__/index.test.ts

@@ -66,6 +66,6 @@ describe('transformImage plugin', () => {
     const errorMock = jest.spyOn(console, 'warn').mockImplementation(() => {});
     const result = await processFixture('invalid-img', {staticDirs});
     expect(result).toMatchSnapshot();
-    expect(errorMock).toBeCalledTimes(1);
+    expect(errorMock).toHaveBeenCalledTimes(1);
   });
 });

packages/docusaurus-plugin-content-blog/src/__tests__/feed.test.ts

@@ -98,7 +98,7 @@ describe.each(['atom', 'rss', 'json'])('%s', (feedType) => {
       } as PluginOptions,
     );
 
-    expect(fsMock).toBeCalledTimes(0);
+    expect(fsMock).toHaveBeenCalledTimes(0);
     fsMock.mockClear();
   });
 

packages/docusaurus-plugin-content-docs/src/sidebars/__tests__/index.test.ts

@@ -175,12 +175,12 @@ describe('loadSidebars', () => {
         } as VersionMetadata,
       }),
     ).rejects.toThrowErrorMatchingInlineSnapshot(`""foo" is not allowed"`);
-    expect(consoleWarnMock).toBeCalledWith(
+    expect(consoleWarnMock).toHaveBeenCalledWith(
       expect.stringMatching(
         /.*\[WARNING\].* There are more than one category metadata files for .*foo.*: foo\/_category_.json, foo\/_category_.yml. The behavior is undetermined./,
       ),
     );
-    expect(consoleErrorMock).toBeCalledWith(
+    expect(consoleErrorMock).toHaveBeenCalledWith(
       expect.stringMatching(
         /.*\[ERROR\].* The docs sidebar category metadata file .*foo\/_category_.json.* looks invalid!/,
       ),

packages/docusaurus-utils-validation/src/__tests__/validationUtils.test.ts

@@ -59,7 +59,7 @@ describe('normalizePluginOptions', () => {
         options,
       ),
     ).toEqual({foo: 'a', id: 'default'});
-    expect(consoleMock).toBeCalledWith(
+    expect(consoleMock).toHaveBeenCalledWith(
       expect.stringMatching(/"foo" deprecated/),
     );
   });
@@ -110,7 +110,7 @@ describe('normalizeThemeConfig', () => {
         themeConfig,
       ),
     ).toEqual(themeConfig);
-    expect(consoleMock).toBeCalledWith(
+    expect(consoleMock).toHaveBeenCalledWith(
       expect.stringMatching(/"foo" deprecated/),
     );
   });

packages/docusaurus-utils/src/__tests__/emitUtils.test.ts

@@ -104,15 +104,15 @@ describe('generate', () => {
 
   it('works with existing cache', async () => {
     await generate(__dirname, 'foo', 'bar');
-    expect(writeMock).toBeCalledTimes(1);
+    expect(writeMock).toHaveBeenCalledTimes(1);
   });
 
   it('works with existing file but no cache', async () => {
     existsMock.mockImplementationOnce(() => true);
     // @ts-expect-error: seems the typedef doesn't understand overload
     readMock.mockImplementationOnce(() => Promise.resolve('bar'));
     await generate(__dirname, 'baz', 'bar');
-    expect(writeMock).toBeCalledTimes(1);
+    expect(writeMock).toHaveBeenCalledTimes(1);
   });
 
   it('works when force skipping cache', async () => {

packages/docusaurus-utils/src/__tests__/gitUtils.test.ts

@@ -120,15 +120,15 @@ describe('getFileCommitDate', () => {
         age: 'newest',
         includeAuthor: true,
       }),
-    ).toThrowError(FileNotTrackedError);
+    ).toThrow(FileNotTrackedError);
   });
   it('throws when file not found', async () => {
     expect(() =>
       getFileCommitDate(path.join(repoDir, 'nonexistent.txt'), {
         age: 'newest',
         includeAuthor: true,
       }),
-    ).toThrowError(
+    ).toThrow(
       /Failed to retrieve git history for ".*nonexistent.txt" because the file does not exist./,
     );
   });

packages/docusaurus/src/client/__tests__/normalizeLocation.test.ts

@@ -98,7 +98,7 @@ describe('normalizeLocation', () => {
       search: '',
       hash: '#features',
     });
-    expect(replaceMock).toBeCalledTimes(1);
+    expect(replaceMock).toHaveBeenCalledTimes(1);
 
     expect(
       normalizeLocation({

packages/docusaurus/src/server/__tests__/brokenLinks.test.ts

@@ -107,7 +107,7 @@ describe('handleBrokenLinks', () => {
 
   it('do not report anything for correct paths', async () => {
     const consoleMock = jest
-      .spyOn(console, 'error')
+      .spyOn(console, 'warn')
       .mockImplementation(() => {});
     const allCollectedCorrectLinks = {
       '/docs/good doc with space': [
@@ -136,12 +136,12 @@ describe('handleBrokenLinks', () => {
     };
     await handleBrokenLinks({
       allCollectedLinks: allCollectedCorrectLinks,
-      onBrokenLinks: 'error',
+      onBrokenLinks: 'warn',
       routes,
       baseUrl: '/',
       outDir,
     });
-    expect(consoleMock).toBeCalledTimes(0);
+    expect(consoleMock).toHaveBeenCalledTimes(0);
   });
 
   it('reports all broken links', async () => {
@@ -167,7 +167,7 @@ describe('handleBrokenLinks', () => {
       baseUrl: '/',
       outDir,
     });
-    expect(lodashMock).toBeCalledTimes(0);
+    expect(lodashMock).toHaveBeenCalledTimes(0);
     lodashMock.mockRestore();
   });
 

packages/docusaurus/src/server/__tests__/configValidation.test.ts

@@ -184,7 +184,7 @@ describe('normalizeConfig', () => {
       normalizeConfig({
         plugins,
       } as Config);
-    }).not.toThrowError();
+    }).not.toThrow();
   });
 
   it.each([
@@ -223,7 +223,7 @@ describe('normalizeConfig', () => {
       normalizeConfig({
         themes,
       } as Config);
-    }).not.toThrowError();
+    }).not.toThrow();
   });
 
   it('throws error if themes is not array', () => {

packages/docusaurus/src/server/__tests__/routes.test.ts

@@ -96,7 +96,7 @@ describe('handleDuplicateRoutes', () => {
     }).toThrowErrorMatchingSnapshot();
     const consoleMock = jest.spyOn(console, 'log').mockImplementation(() => {});
     handleDuplicateRoutes(routes, 'ignore');
-    expect(consoleMock).toBeCalledTimes(0);
+    expect(consoleMock).toHaveBeenCalledTimes(0);
   });
 });
 

packages/docusaurus/src/server/translations/__tests__/translations.test.ts

@@ -76,7 +76,7 @@ describe('writeCodeTranslations', () => {
       key2: {message: 'key2 message'},
       key3: {message: 'key3 message'},
     });
-    expect(consoleInfoMock).toBeCalledWith(
+    expect(consoleInfoMock).toHaveBeenCalledWith(
       expect.stringMatching(/3.* translations will be written/),
     );
   });
@@ -100,7 +100,7 @@ describe('writeCodeTranslations', () => {
       key2: {message: 'PREFIX key2 message'},
       key3: {message: 'PREFIX key3 message'},
     });
-    expect(consoleInfoMock).toBeCalledWith(
+    expect(consoleInfoMock).toHaveBeenCalledWith(
       expect.stringMatching(/3.* translations will be written/),
     );
   });
@@ -129,7 +129,7 @@ describe('writeCodeTranslations', () => {
       key3: {message: 'key3 message'},
       key4: {message: 'key4 message new'},
     });
-    expect(consoleInfoMock).toBeCalledWith(
+    expect(consoleInfoMock).toHaveBeenCalledWith(
       expect.stringMatching(/4.* translations will be written/),
     );
   });
@@ -154,7 +154,7 @@ describe('writeCodeTranslations', () => {
       key1: {message: 'key1 message'},
       key2: {message: 'PREFIX key2 message new'},
     });
-    expect(consoleInfoMock).toBeCalledWith(
+    expect(consoleInfoMock).toHaveBeenCalledWith(
       expect.stringMatching(/2.* translations will be written/),
     );
   });
@@ -179,7 +179,7 @@ describe('writeCodeTranslations', () => {
       key1: {message: 'key1 message new'},
       key2: {message: 'key2 message new'},
     });
-    expect(consoleInfoMock).toBeCalledWith(
+    expect(consoleInfoMock).toHaveBeenCalledWith(
       expect.stringMatching(/2.* translations will be written/),
     );
   });
@@ -205,7 +205,7 @@ describe('writeCodeTranslations', () => {
       key1: {message: 'PREFIX key1 message new'},
       key2: {message: 'PREFIX key2 message new'},
     });
-    expect(consoleInfoMock).toBeCalledWith(
+    expect(consoleInfoMock).toHaveBeenCalledWith(
       expect.stringMatching(/2.* translations will be written/),
     );
   });
@@ -232,7 +232,7 @@ describe('writeCodeTranslations', () => {
       key2: {message: 'key2 message', description: 'key2 desc new'},
       key3: {message: 'key3 message', description: 'key3 desc new'},
     });
-    expect(consoleInfoMock).toBeCalledWith(
+    expect(consoleInfoMock).toHaveBeenCalledWith(
       expect.stringMatching(/3.* translations will be written/),
     );
   });
@@ -242,10 +242,10 @@ describe('writeCodeTranslations', () => {
 
     await writeCodeTranslations({localizationDir}, {}, {});
 
-    await expect(readFile()).rejects.toThrowError(
+    await expect(readFile()).rejects.toThrow(
       /ENOENT: no such file or directory, open /,
     );
-    expect(consoleInfoMock).toBeCalledTimes(0);
+    expect(consoleInfoMock).toHaveBeenCalledTimes(0);
   });
 
   it('throws for invalid content', async () => {

packages/docusaurus/src/server/translations/__tests__/translationsExtractor.test.ts

@@ -64,7 +64,7 @@ const default => {
       extractSourceCodeFileTranslations(sourceCodeFilePath, TestBabelOptions),
     ).rejects.toThrow();
 
-    expect(errorMock).toBeCalledWith(
+    expect(errorMock).toHaveBeenCalledWith(
       expect.stringMatching(
         /Error while attempting to extract Docusaurus translations from source code file at/,
       ),

packages/docusaurus/src/webpack/__tests__/base.test.ts

@@ -122,6 +122,6 @@ describe('base webpack config', () => {
       .mockImplementation(() => fileLoaderUtils);
 
     await createBaseConfig(props, false, false);
-    expect(mockSvg).toBeCalled();
+    expect(mockSvg).toHaveBeenCalled();
   });
 });

packages/docusaurus/src/webpack/__tests__/utils.test.ts

@@ -346,13 +346,13 @@ describe('getHttpsConfig', () => {
     process.env.HTTPS = 'true';
     process.env.SSL_CRT_FILE = path.join(__dirname, '__fixtures__/host.crt');
     process.env.SSL_KEY_FILE = path.join(__dirname, '__fixtures__/invalid.key');
-    await expect(getHttpsConfig()).rejects.toThrowError();
+    await expect(getHttpsConfig()).rejects.toThrow();
   });
 
   it('throws for invalid cert', async () => {
     process.env.HTTPS = 'true';
     process.env.SSL_CRT_FILE = path.join(__dirname, '__fixtures__/invalid.crt');
     process.env.SSL_KEY_FILE = path.join(__dirname, '__fixtures__/host.key');
-    await expect(getHttpsConfig()).rejects.toThrowError();
+    await expect(getHttpsConfig()).rejects.toThrow();
   });
 });