Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Jest collectCoverageFrom option #890

Closed
robcaldecott opened this issue Oct 11, 2016 · 7 comments
Closed

Support Jest collectCoverageFrom option #890

robcaldecott opened this issue Oct 11, 2016 · 7 comments

Comments

@robcaldecott
Copy link

jestjs/jest#1211

When Jest performs code coverage, it seems to only cover the files that were tested instead of all files in my source directory. This gives a skewed percentage of files tested.

Jest 15 added a new config option for this called `collectCoverageFrom``

Can we have support for this in CRA?
@gaearon
Copy link
Contributor

gaearon commented Oct 11, 2016

We can add it to our config. Should it just look at app's src/? Would you like to send a PR?

@mackbyte
Copy link
Contributor

mackbyte commented Oct 17, 2016 •
edited
Loading

Seems someone else raised a PR:

pick up all files for coverage reporting #905

@mackbyte
Copy link
Contributor

Any update on this ? Is the PR acceptable ? I notice its not CLA signed so does it need to be resubmitted ?

@mackbyte
Copy link
Contributor

I submitted a pull request #961
Let me know if its acceptable.

@gaearon
Copy link
Contributor

gaearon commented Nov 20, 2016

Fixed in #961, will be out in 0.8.0.

@gaearon gaearon closed this as completed Nov 20, 2016
@gaearon gaearon added this to the 0.10.0 milestone May 16, 2017
@gaearon
Copy link
Contributor

gaearon commented May 16, 2017

It is also configurable in the next version.
#1830

@gaearon gaearon removed this from the 0.10.0 milestone May 16, 2017
@gaearon
Copy link
Contributor

gaearon commented May 16, 2017

Please help beta test the new version that includes this change!
#2172

@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@robcaldecott @gaearon @mackbyte