Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forked react-scripts should retain the binary name #753

Closed
gaearon opened this issue Sep 25, 2016 · 0 comments
Closed

Forked react-scripts should retain the binary name #753

gaearon opened this issue Sep 25, 2016 · 0 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented Sep 25, 2016 •
edited
Loading

Claimed by @shubheksha

People who fork react-scripts shoulldn’t need to rename their bin script because this is annoying. Ideally changing just name in their react-scripts fork’s package.json should be enough.

Looks like #728 made some things better but some things worse. We should keep the part of it where it reads the correct path and removes the correct dependencies, but we should revert the changes to binary names and hardcode react-scripts again there.
@shubheksha shubheksha mentioned this issue Sep 25, 2016
Merged
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaearon