Paths are incorrectly resolved when react-scripts is a shared dependency

[gaearon]

Not sure if we want to (or even can) support this use case, but this doesn't currently work:

- proj
  - package.json # contains react-scripts
  - node_modules
    - react-scripts
  - a
    - package.json # does not contain react-scripts but has npm start
    - src
  - b
    - package.json # does not contain react-scripts but has npm start
    - src

Technically this is valid in npm, but CRA thinks it’s running in local development mode.

[gaearon]

@Jiansen Could you take a look at this? Curious if you have ideas.

[gaearon]

The good part is this never worked before, so at least it’s not a regression.

[Jiansen]

I will take a look. @remove-on-publish-begin/end should remove local dev only code.

Before we had @remove-on-publish/eject-begin/end, we use path compare to determine if CRA is running in local dev, as an npm module, or after eject. We should hopefully be able to remove those checks now.

[gaearon]

Thanks!

[Timer]

Retagging this for 0.10, but we might've already fixed this with our recent path changes.
Please check before working on it. :)

[gaearon]

I think the remaining issue will be fixed by #2166.