Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly build message on master #2190

Closed
Timer opened this issue May 17, 2017 · 1 comment · Fixed by #2202
Closed

Ugly build message on master #2190

Timer opened this issue May 17, 2017 · 1 comment · Fixed by #2202
Milestone

Comments

@Timer
Copy link
Contributor

Timer commented May 17, 2017

While testing PWA I ran into this:

Joes-MacBook-Pro:website joe$ yarn build
yarn build v0.24.4
$ react-scripts build 
Creating an optimized production build...
Total precache size is about 3.15 MB for 11 resources.
Failed to compile.

9:0-8 "export 'register' was not found in './register'

Looks fine when running yarn start:

@Timer Timer added this to the 1.0.1 milestone May 17, 2017
@gaearon
Copy link
Contributor

gaearon commented May 17, 2017

In general I think we should reformat common Webpack errors and show them with better messages and more instructions on how to fix (e.g. "this error is commonly caused by [...]")

@gaearon gaearon modified the milestones: 1.0.1, 1.0.0 May 19, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants