Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack 2 Dynamic Imports are Very Slow #2176

Closed
gaearon opened this issue May 16, 2017 · 5 comments
Closed

Webpack 2 Dynamic Imports are Very Slow #2176

gaearon opened this issue May 16, 2017 · 5 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented May 16, 2017

While we officially support dynamic import() proposal, it is reported to have significant build performance issues (#2172 (comment), webpack/webpack#4636).

We are going to de-emphasize their support in the documentation until Webpack fixes them. I will disable the require.ensure deprecation, and will track re-enabling it in this issue.

@gaearon
Copy link
Contributor Author

gaearon commented May 16, 2017

Setting this up as needing contributions. Specifically, we need somebody to help Webpack folks in webpack/webpack#4636 reliably reproduce the performance issue.

@ingro
Copy link
Contributor

ingro commented May 24, 2017

Release 2.6.0. of webpack improved the handling of import, maybe the dependency could be updated in react-scripts too?

@gaearon
Copy link
Contributor Author

gaearon commented May 24, 2017

Yea, we plan to bump to 2.6.0. Want to send a PR?

@ingro
Copy link
Contributor

ingro commented May 24, 2017

Sure, that seems an easy enough PR to start with :P

@gaearon
Copy link
Contributor Author

gaearon commented May 27, 2017

react-scripts@1.0.7 now use Webpack 2 which supports import hints: webpack/webpack#4807 (comment).
Please give it a try!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants