Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error overlay should show code for collapsed frames #2144

Closed
gaearon opened this issue May 14, 2017 · 1 comment · Fixed by #2145
Closed

Error overlay should show code for collapsed frames #2144

gaearon opened this issue May 14, 2017 · 1 comment · Fixed by #2145

Comments

@gaearon
Copy link
Contributor

gaearon commented May 14, 2017

I think we should probably change the way collapsed frames work.
This is confusing because I don't see the actual place where the error happened, even if I expand:

screen shot 2017-05-14 at 12 26 15

I see my code immediately, which is valuable, but the error message makes full sense only in the context of the line that has thrown.

Ideally I think we should change the collapsed frames to also show the code, but they should be highlighted as a separate vertical block with its own distinct background. This way it’s also easier to keep track of where the collapsed section begins and ends.

@gaearon gaearon added this to the 0.10.1 milestone May 14, 2017
@gaearon
Copy link
Contributor Author

gaearon commented May 14, 2017

Maybe we should just avoid collapsing extra frames for TypeErrors since they're usually unexpected.

@gaearon gaearon modified the milestones: 1.0.1, 1.0.0 May 19, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant