Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd function name in the crash overlay #2097

Closed
gaearon opened this issue May 8, 2017 · 9 comments
Closed

Odd function name in the crash overlay #2097

gaearon opened this issue May 8, 2017 · 9 comments

Comments

@gaearon
Copy link
Contributor

gaearon commented May 8, 2017

If I add <Lol /> to the default template, I see a weird function name in the overlay stack:

screen shot 2017-05-08 at 5 37 52 pm

Any ideas as to where it is coming from?

@gaearon gaearon added this to the 0.10.1 milestone May 8, 2017
@Timer
Copy link
Contributor

Timer commented May 8, 2017

@Timer
Copy link
Contributor

Timer commented May 8, 2017

🐛 in chrome

Chrome is who is reporting this function name, not any of our code:

This works correctly in firefox:

And safari:

@gaearon
Copy link
Contributor Author

gaearon commented May 9, 2017

Shall we file a bug with Chrome? Looks like Chrome infers function name from the name of first variable inside of it. cc @bmeurer

@bmeurer
Copy link

bmeurer commented May 9, 2017

I don't know about that part. @gsathya will probably know.

@bmeurer
Copy link

bmeurer commented May 9, 2017

cc @ajklein

@gsathya
Copy link
Member

gsathya commented May 9, 2017

Looks like Chrome infers function name from the name of first variable inside of it.

How do I repro this? This doesn't seem to happen on chrome for something like (function() { var x = 'x'; throw new Error('wat') })();

@gaearon
Copy link
Contributor Author

gaearon commented May 9, 2017

Tagging as up for grabs because we need somebody to create a reduced test case for Chrome.

For now, to reproduce the issue you'd need to clone this project, run npm install, and npm start, and then add throw new Error('oops') in this file, then look at the error box (which will use the function name).

@gaearon
Copy link
Contributor Author

gaearon commented May 14, 2017

Another one I'm seeing: Object.exports.__esModule. Need to remember to filter that out too.

@gaearon gaearon modified the milestones: 1.0.1, 1.0.x May 19, 2017
@gaearon
Copy link
Contributor Author

gaearon commented Jan 8, 2018

Meh.

@gaearon gaearon closed this as completed Jan 8, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants