Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ejecting should ensure you have clean git status (if you use git) and ask you to commit #2082

Closed
gaearon opened this issue May 4, 2017 · 1 comment

Comments

@gaearon
Copy link
Contributor

gaearon commented May 4, 2017

We don't currently integrate with Git, so probably shouldn't commit on your behalf.

But I think we should refuse to eject if you use Git and have dirty Git status.
Right after ejecting, we should also nudge you to commit the change.

This way it's easier to revert an ejection in the future.

Based on conversation with @thejameskyle in https://twitter.com/thejameskyle/status/860133102655602688

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants