Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove remaining stylistic rules from ESLint config #2057

Closed
gaearon opened this issue May 1, 2017 · 2 comments
Closed

Remove remaining stylistic rules from ESLint config #2057

gaearon opened this issue May 1, 2017 · 2 comments
Labels
contributions: claimed difficulty: starter tag: enhancement
Milestone
1.0.0

Comments

@gaearon
Copy link
Contributor

gaearon commented May 1, 2017 •
edited
Loading

As discussed in #1948, there are still a few ESLint warnings about the style in our config. We should just remove them. If one wants to enforce style, they can just use Prettier.
@gaearon gaearon added this to the 0.10.0 milestone May 1, 2017
@gaearon gaearon mentioned this issue May 1, 2017
Closed
@anilreddykatta
Copy link
Contributor

@gaearon we want to get rid of all warn in our eslint? Do you have any specific set of rules? I can send a PR. 👍

@gaearon
Copy link
Contributor Author

gaearon commented May 1, 2017 •
edited
Loading

No, we keep the warn, but we remove those that are purely stylistic (i.e. warn about ugly spacing rather than real problems in the code). I think we only have one or two such rules, related to JSX.

@anilreddykatta anilreddykatta mentioned this issue May 2, 2017
Merged
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: claimed difficulty: starter tag: enhancement
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@gaearon @anilreddykatta