Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When build is failing due to ESLint errors, filter warnings out #2056

Closed
gaearon opened this issue May 1, 2017 · 1 comment · Fixed by #2120
Closed

When build is failing due to ESLint errors, filter warnings out #2056

gaearon opened this issue May 1, 2017 · 1 comment · Fixed by #2120
Labels
contributions: claimed difficulty: starter issue: bug
Milestone
1.0.0

Comments

@gaearon
Copy link
Contributor

gaearon commented May 1, 2017

Currently, we have a few ESLint rules configured to produce errors. Such as no-undefined rule.

However, when we display the error overlay, we also show warnings in it. This is confusing because people don’t realize only errors need to be fixed to proceed.

We should fix it so that if the output contains any ESLint errors, we should omit any mention of warnings.
@gaearon gaearon added this to the 0.10.0 milestone May 1, 2017
@gaearon gaearon mentioned this issue May 1, 2017
Closed
@Timer
Copy link
Contributor

Timer commented May 1, 2017

#2059

@gaearon gaearon mentioned this issue May 11, 2017
Merged
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
contributions: claimed difficulty: starter issue: bug
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Omit ESLint warnings when there are ESLint errors gaearon/create-react-app
2 participants
@Timer @gaearon