Fix AppVeyor CI

[gaearon]

It’s been broken for a few days.
You can look at CI failures in all recent PRs and try to figure out what happened.

[Timer]

The lerna team mentioned there may be async contention issues on Windows, maybe someone can try setting the concurrency flag to 1 for AppVeyor.

[darrenscerri]

@Timer, setting concurrency to 1 didn't fix the issue (#1868)

[Timer]

You set the concurrency for AppVeyor, the flag I was referring to was a flag you need to pass to Lerna itself. 😄
I realize my comment could've been taken wrong, "for [Lerna on] AppVeyor". This flag should not be necessary for Travis and would cause unnecessary slowdown.

[darrenscerri]

Sorry, my bad! Added the concurrency flag to Lerna commands. Will check if this fixes the AppVeyor issue, if yes, will add logic to enable this flag only on AppVeyor to avoid unnecessary slowdowns otherwise.

[darrenscerri]

Setting concurrency to 1 on Lerna still didn't fix the issue unfortunately

[Timer]

I believe it may have fixed the erratic failures, but the curl is not recognized is a new error. I'm not sure what is causing that, as it has passed previously. Can you please look into this?

[Timer]

Looks like it's a known problem, AppVeyor updated Git and this regressed, see appveyor/ci#1426.
Looks like they don't plan on fixing it for a couple days, maybe try one of the suggested workarounds with a comment to remove?

[gaearon]

Great job nailing it down.

[darrenscerri]

Unfortunately build is passing just for the master branch, 0.9.x is still failing.

[gaearon]

Can we cherry pick the same fix there?

[darrenscerri]

I actually cherry-picked the fix from 0.9.x to master. There is something else going on in that branch.

[gaearon]

Let's keep it open for now then

[darrenscerri]

This issue has been fixed by #1876 and #1868.

[Timer]

Perfect! Any remaining issues are due to lerna bugs which are less present on VS2017 image.

Can you keep us posted for when they fix the curl path issue? Thanks!

I want to close this since further improvement is unactionable by us (unless if we switch from lerna bootstrap to a lerna exec npm install with concurrency 1 then bootstrap).

I just want to make sure the lerna team is aware of this issue. I believe they are. Could you double check for me? I'm tied up for a few days.

[darrenscerri]

As for the curl path issue, I'll keep an eye on this.

As for the Lerna issue, it seems that there are some issues open already but all are mentioning yarn. The failing builds were all using npm, and all failed at the same exact place. Opened issue lerna/lerna#716 on the Lerna repo.

It might also just be a memory issue as mentioned in lerna/lerna#338.

In the meantime, take a look at this commit darrenscerri@19cda22. There's a script that adds the concurrency=1 flag in lerna.json just for AppVeyor. Let me know if this might be worth merging.

[Timer]

If that consistently fixes the problem it may be worth implementing in a slightly different way. We should handle it in the e2e test files (sh), not as a node script.

[darrenscerri]

I will run the build multiple times to confirm that it consistently fixes the problem and will report back.

Check out the latest commit darrenscerri@19cda22. I moved the script in the tasks directory.

Since this is AppVeyor-specific, I don't agree with putting this logic in the e2e sh files when AppVeyor provides a hook to execute arbitrary commands before the build. Otherwise we would have to add conditional logic in the shell script to check whether we are inside an AppVeyor environment. And it will be quite overkill and inappropriate to use a shell script to modify a JSON file.

EDIT: Still failing :(

[gaearon]

Seems like it’s fine now.