Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable ES6 modules via Webpack when they stop breaking sourcemaps #1744

Closed
gaearon opened this issue Mar 7, 2017 · 4 comments
Closed

Re-enable ES6 modules via Webpack when they stop breaking sourcemaps #1744

gaearon opened this issue Mar 7, 2017 · 4 comments
Labels
tag: enhancement
Milestone
100.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Mar 7, 2017

We disabled them in #1742 because of #1638 (webpack/webpack#4423).
@gaearon gaearon added this to the 1.0.0 milestone Mar 7, 2017
@Vanuan
Copy link

Vanuan commented Apr 2, 2017

It looks fine in 2.3.2. Though there are still some non-critical issues with adding a breakpoint in places with 1-to-many lines tranformation.

@gaearon
Copy link
Contributor Author

gaearon commented Apr 2, 2017

Yea, I think we actually merged a PR that re-enables them in master.

@gaearon gaearon closed this as completed Apr 2, 2017
@Timer
Copy link
Contributor

Timer commented Apr 2, 2017

I believe one-to-many relations have always been a problem, but it's not blocking.

@Timer
Copy link
Contributor

Timer commented Apr 2, 2017

They were re-enabled in #1894. 😄

@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tag: enhancement
Projects
None yet
Milestone
100.0
Development

No branches or pull requests
3 participants
@Vanuan @Timer @gaearon