Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Red Box] Umbrella issue for remaining polish #1129

Closed
27 of 30 tasks
Timer opened this issue Dec 1, 2016 · 1 comment
Closed
27 of 30 tasks

[Red Box] Umbrella issue for remaining polish #1129

Timer opened this issue Dec 1, 2016 · 1 comment
Milestone

Comments

@Timer
Copy link
Contributor

Timer commented Dec 1, 2016

This is an umbrella issue for remaining Red Box issues. Please let me know if I forgot any.
PR: #1101

Blockers

  • Clicking arrows currently makes their text select. Are those implemented as buttons? We need to make sure clicking doesn't select text.
  • We also need to make sure this dialog is accessible. Can you please read accessibility guidelines for dialogs and make sure we follow as much as possible? This might mean specifying some ARIA attributes etc.
  • Good point, this should also look reasonably well with mobile exultation.
  • There is an annoying screen jump when switching between source / compiled because compiled includes a line with ^. In a perfect world I would like to see the line with | ^ get hidden, and instead see ^ rendered absolutely below the offending character. Yeah I know this is not fun. 😄
  • Failing eject (only on CI?) Add runtime error overlay #1101 (comment)
  • webpack/core patch Bump source-map-list to 0.1.7 webpack/core#30 (comment)
  • babel-code-frame indentation Add runtime error overlay #1101 (comment)
  • Double scrollbar—main content must never scroll horizontally Add runtime error overlay #1101 (comment)
  • Message at the bottom Add runtime error overlay #1101 (comment)
  • (Unrelated but I'd like to see this addressed) Add runtime error overlay #1101 (comment)
  • Some design work on the syntax overlay screen to make them more visually cohesive. Not just in palette but in how they feel like. Syntax overlay is a lazy "terminal" output and wasn't really "designed". I'm not sure how to fix this and I don't want to block the PR on this but we need to make a conscious decision here.
  • Remove use of environment variable to force color https://github.com/Timer/create-react-app/issues/11

@Timer Timer added this to the 0.10.0 milestone Mar 22, 2017
@gaearon
Copy link
Contributor

gaearon commented May 15, 2017

It's okay now. 😄
We can do more later in a separate pass.

@gaearon gaearon closed this as completed May 15, 2017
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants