Math/extent conversion #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! Yeah |
bhousel
reviewed
Jul 26, 2021
bhousel
reviewed
Jul 26, 2021
bhousel
reviewed
Jul 26, 2021
This reverts commit 7ba89ce.
|
Unfortunately it looks like ways are still broken after I made the changes @bhousel suggested. Something else is going on here- no way data is making it into the OSM Layer data. I suspect some wonky extent logic is masking the data from making it to the rendering pipeline. |
… candidate for Extent() conversion.
Bonkles
added
feature-sdk
|
Merging after our sync discussion on friday. |
|
merging as per our sync meeting friday! |
zlavergne
pushed a commit
that referenced
this pull request
Aug 3, 2021
* Move CrossEditableZoom event firing. It should happen after projection is transformed. * Bump versions * Switch to Mapillary API v4 * Fix traffic sign rendering and geometry conversion * Remove debugging code * Update locale file * Removing redundant @mapbox/geojson-rewind dep pkg * Remove unused map feature title * Bring map map feature tooltips * Add missing mapillary map feature classes * Update translation file * Bing imagery - Ensure freshness * bingImagery strict n param. Fallback url tempalate to latest * minor revert catch log * some bing imagery docs comments * typo * Add aws_deploy npm action to build workflow (#229) * Add aws_deploy npm action to build workflow Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script. * Hopefully more verbose logging when amazon fails * DO NOT MERGE: Adding hook for this branch to test on github * Better capture failure cases of aws calls * Going with the middle spam level for logging * Replace Rollup with Esbuild. (#246) * Add new esbuild-based quickstart directive. * Get the esbuild legacy build working, save for issues with NSI. * Upgrade several dependencies, bump minimum node version to 12 - country-coder (closes #249) - location-conflation (closes #248) - osm-community-index (closes #250) - name-suggestion-index * Bump marked from 2.0.7 to 2.1.2 Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v2.0.7...v2.1.2) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Add the es5 directive back. * Get dev builds working once again, normal builds still slightly wonky. * Get some sort of legacy build working by converting requires() to import statements. * Fix target for esbuild legacy build * Move build all directive to use esbuild. * Add visualizer capability and build directive. * Remove rollup from dependency list completely! Co-authored-by: Bryan Housel <bhousel@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove special case for push to deploy_with_action This was just used during development * Clean up log, and add link to build result * One too many slashes * Is this simple conditional good enough? * Better syntax? * Now with correct syntax * Bump osm-community-index from 5.0.1 to 5.1.0 Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/osmlab/osm-community-index/releases) - [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md) - [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: osm-community-index dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump osm-community-index from 5.0.1 to 5.1.0 * If locationSet is missing `include`, default to worldwide include openstreetmap/iD#8305 (comment) * pacify eslint, fix merge goof in map.js * Build sourcemap too * Use pagination to fetch all the esri datasets (closes #257) * Bump object-inspect from 1.10.3 to 1.11.0 Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0. - [Release notes](https://github.com/inspect-js/object-inspect/releases) - [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: object-inspect dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * gitignore esbuild.json It changes on every build and is only use to rebuild the stats * Bump osm-community-index to 5.1.1 * Modernize more scripts (convert require to import) * npm run imagery * npm run translations * rapid-v1.1.5 * Set z-index of absolutely positioned layers under supersurface Each of these has their own internal stacking context * npm run translations * Fix link * Math/extent conversion (#272) * Bump version to newest id-sdk release. * Convert geoExtent to id-sdk/Extent. Most tests working. * Fix remaining tests. * Remove geo modules no longer in use. * Revert "Fix remaining tests." This reverts commit 7ba89ce. * Fix a number of instances of extents being used as raw tuples. * Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion. * Fix roads/ways not appearing in the map, also fix a crossing ways test problem. * Fix an issue with the measurement panel not setting its extent correctly. * fix usages of Extend.extend() because it no longer modifies the extent in-place. * Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity. * add service module for querying streetview suggestions (#192) * Show suggestion images and viewfield icon * fix PR comments * hightlight images and viewfields on hover * Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right. * Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly. * Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk. * Fix bug that was selecting the wrong service when we selected a sidewalk suggestion. * Get image strip working with Bryan's help. * Fix sorting of images by longitude. * Improve styling of the image strip, and add 'enlarge on mouse hover' interaction. * style suggested sidewalks * Parse crosswalk data * remove console.log statement * Fix debug messages that shouldn't have been checked in. * Fix issue that was causing too many viewfield nodes to appear. * fix hovering issues * Fix some linter errors. * Make 5 images not require a scrollbar in the image strip, even when one is zoomed. * Fix images to all have the same height, not the same width. * Fix code drift issues that had occurred in main. Co-authored-by: Milos Brzakovic (E-Search) <mbrzakovic@microsoft.com> Co-authored-by: Bryan Housel <bhousel@gmail.com> Co-authored-by: Nikola Pleša <nikolaplesa@fb.com> Co-authored-by: Milos Brzakovic <78906108+mbrzakovic@users.noreply.github.com> Co-authored-by: Danny Krause <vanreece@gmail.com> Co-authored-by: Ben Clark <bennyc@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Gao <mkobie@gmail.com> Co-authored-by: Amol Vasant Khadilkar <amolk@fb.com> Co-authored-by: Benjamin Clark <clarkben@fb.com>
Bonkles
added a commit
that referenced
this pull request
Aug 27, 2021
* Move CrossEditableZoom event firing. It should happen after projection is transformed. * Bump versions * Switch to Mapillary API v4 * Fix traffic sign rendering and geometry conversion * Remove debugging code * Update locale file * Removing redundant @mapbox/geojson-rewind dep pkg * Remove unused map feature title * Bring map map feature tooltips * Add missing mapillary map feature classes * Update translation file * Bing imagery - Ensure freshness * bingImagery strict n param. Fallback url tempalate to latest * minor revert catch log * some bing imagery docs comments * typo * Add aws_deploy npm action to build workflow (#229) * Add aws_deploy npm action to build workflow Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script. * Hopefully more verbose logging when amazon fails * DO NOT MERGE: Adding hook for this branch to test on github * Better capture failure cases of aws calls * Going with the middle spam level for logging * Replace Rollup with Esbuild. (#246) * Add new esbuild-based quickstart directive. * Get the esbuild legacy build working, save for issues with NSI. * Upgrade several dependencies, bump minimum node version to 12 - country-coder (closes #249) - location-conflation (closes #248) - osm-community-index (closes #250) - name-suggestion-index * Bump marked from 2.0.7 to 2.1.2 Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v2.0.7...v2.1.2) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Add the es5 directive back. * Get dev builds working once again, normal builds still slightly wonky. * Get some sort of legacy build working by converting requires() to import statements. * Fix target for esbuild legacy build * Move build all directive to use esbuild. * Add visualizer capability and build directive. * Remove rollup from dependency list completely! Co-authored-by: Bryan Housel <bhousel@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove special case for push to deploy_with_action This was just used during development * Clean up log, and add link to build result * One too many slashes * Is this simple conditional good enough? * Better syntax? * Now with correct syntax * Bump osm-community-index from 5.0.1 to 5.1.0 Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/osmlab/osm-community-index/releases) - [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md) - [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: osm-community-index dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump osm-community-index from 5.0.1 to 5.1.0 * If locationSet is missing `include`, default to worldwide include openstreetmap/iD#8305 (comment) * pacify eslint, fix merge goof in map.js * Build sourcemap too * Use pagination to fetch all the esri datasets (closes #257) * Bump object-inspect from 1.10.3 to 1.11.0 Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0. - [Release notes](https://github.com/inspect-js/object-inspect/releases) - [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: object-inspect dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * gitignore esbuild.json It changes on every build and is only use to rebuild the stats * Bump osm-community-index to 5.1.1 * Modernize more scripts (convert require to import) * npm run imagery * npm run translations * rapid-v1.1.5 * Set z-index of absolutely positioned layers under supersurface Each of these has their own internal stacking context * npm run translations * Fix link * Math/extent conversion (#272) * Bump version to newest id-sdk release. * Convert geoExtent to id-sdk/Extent. Most tests working. * Fix remaining tests. * Remove geo modules no longer in use. * Revert "Fix remaining tests." This reverts commit 7ba89ce. * Fix a number of instances of extents being used as raw tuples. * Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion. * Fix roads/ways not appearing in the map, also fix a crossing ways test problem. * Fix an issue with the measurement panel not setting its extent correctly. * fix usages of Extend.extend() because it no longer modifies the extent in-place. * Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity. * add service module for querying streetview suggestions (#192) * Show suggestion images and viewfield icon * fix PR comments * hightlight images and viewfields on hover * Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right. * Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly. * Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk. * Fix bug that was selecting the wrong service when we selected a sidewalk suggestion. * Get image strip working with Bryan's help. * Fix sorting of images by longitude. * Improve styling of the image strip, and add 'enlarge on mouse hover' interaction. * style suggested sidewalks * Parse crosswalk data * remove console.log statement * Fix debug messages that shouldn't have been checked in. * Fix issue that was causing too many viewfield nodes to appear. * fix hovering issues * Fix some linter errors. * Make 5 images not require a scrollbar in the image strip, even when one is zoomed. * Fix images to all have the same height, not the same width. * Fix code drift issues that had occurred in main. Co-authored-by: Milos Brzakovic (E-Search) <mbrzakovic@microsoft.com> Co-authored-by: Bryan Housel <bhousel@gmail.com> Co-authored-by: Nikola Pleša <nikolaplesa@fb.com> Co-authored-by: Milos Brzakovic <78906108+mbrzakovic@users.noreply.github.com> Co-authored-by: Danny Krause <vanreece@gmail.com> Co-authored-by: Ben Clark <bennyc@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Gao <mkobie@gmail.com> Co-authored-by: Amol Vasant Khadilkar <amolk@fb.com> Co-authored-by: Benjamin Clark <clarkben@fb.com>
Bonkles
added a commit
that referenced
this pull request
Aug 30, 2021
* Move CrossEditableZoom event firing. It should happen after projection is transformed. * Bump versions * Switch to Mapillary API v4 * Fix traffic sign rendering and geometry conversion * Remove debugging code * Update locale file * Removing redundant @mapbox/geojson-rewind dep pkg * Remove unused map feature title * Bring map map feature tooltips * Add missing mapillary map feature classes * Update translation file * Bing imagery - Ensure freshness * bingImagery strict n param. Fallback url tempalate to latest * minor revert catch log * some bing imagery docs comments * typo * Add aws_deploy npm action to build workflow (#229) * Add aws_deploy npm action to build workflow Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script. * Hopefully more verbose logging when amazon fails * DO NOT MERGE: Adding hook for this branch to test on github * Better capture failure cases of aws calls * Going with the middle spam level for logging * Replace Rollup with Esbuild. (#246) * Add new esbuild-based quickstart directive. * Get the esbuild legacy build working, save for issues with NSI. * Upgrade several dependencies, bump minimum node version to 12 - country-coder (closes #249) - location-conflation (closes #248) - osm-community-index (closes #250) - name-suggestion-index * Bump marked from 2.0.7 to 2.1.2 Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v2.0.7...v2.1.2) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Add the es5 directive back. * Get dev builds working once again, normal builds still slightly wonky. * Get some sort of legacy build working by converting requires() to import statements. * Fix target for esbuild legacy build * Move build all directive to use esbuild. * Add visualizer capability and build directive. * Remove rollup from dependency list completely! Co-authored-by: Bryan Housel <bhousel@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove special case for push to deploy_with_action This was just used during development * Clean up log, and add link to build result * One too many slashes * Is this simple conditional good enough? * Better syntax? * Now with correct syntax * Bump osm-community-index from 5.0.1 to 5.1.0 Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/osmlab/osm-community-index/releases) - [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md) - [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: osm-community-index dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump osm-community-index from 5.0.1 to 5.1.0 * If locationSet is missing `include`, default to worldwide include openstreetmap/iD#8305 (comment) * pacify eslint, fix merge goof in map.js * Build sourcemap too * Use pagination to fetch all the esri datasets (closes #257) * Bump object-inspect from 1.10.3 to 1.11.0 Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0. - [Release notes](https://github.com/inspect-js/object-inspect/releases) - [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: object-inspect dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * gitignore esbuild.json It changes on every build and is only use to rebuild the stats * Bump osm-community-index to 5.1.1 * Modernize more scripts (convert require to import) * npm run imagery * npm run translations * rapid-v1.1.5 * Set z-index of absolutely positioned layers under supersurface Each of these has their own internal stacking context * npm run translations * Fix link * Math/extent conversion (#272) * Bump version to newest id-sdk release. * Convert geoExtent to id-sdk/Extent. Most tests working. * Fix remaining tests. * Remove geo modules no longer in use. * Revert "Fix remaining tests." This reverts commit 7ba89ce. * Fix a number of instances of extents being used as raw tuples. * Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion. * Fix roads/ways not appearing in the map, also fix a crossing ways test problem. * Fix an issue with the measurement panel not setting its extent correctly. * fix usages of Extend.extend() because it no longer modifies the extent in-place. * Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity. * add service module for querying streetview suggestions (#192) * Show suggestion images and viewfield icon * fix PR comments * hightlight images and viewfields on hover * Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right. * Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly. * Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk. * Fix bug that was selecting the wrong service when we selected a sidewalk suggestion. * Get image strip working with Bryan's help. * Fix sorting of images by longitude. * Improve styling of the image strip, and add 'enlarge on mouse hover' interaction. * style suggested sidewalks * Parse crosswalk data * remove console.log statement * Fix debug messages that shouldn't have been checked in. * Fix issue that was causing too many viewfield nodes to appear. * fix hovering issues * Fix some linter errors. * Make 5 images not require a scrollbar in the image strip, even when one is zoomed. * Fix images to all have the same height, not the same width. * Fix code drift issues that had occurred in main. Co-authored-by: Milos Brzakovic (E-Search) <mbrzakovic@microsoft.com> Co-authored-by: Bryan Housel <bhousel@gmail.com> Co-authored-by: Nikola Pleša <nikolaplesa@fb.com> Co-authored-by: Milos Brzakovic <78906108+mbrzakovic@users.noreply.github.com> Co-authored-by: Danny Krause <vanreece@gmail.com> Co-authored-by: Ben Clark <bennyc@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Gao <mkobie@gmail.com> Co-authored-by: Amol Vasant Khadilkar <amolk@fb.com> Co-authored-by: Benjamin Clark <clarkben@fb.com>
Bonkles
added a commit
that referenced
this pull request
Oct 7, 2021
* Move CrossEditableZoom event firing. It should happen after projection is transformed. * Bump versions * Switch to Mapillary API v4 * Fix traffic sign rendering and geometry conversion * Remove debugging code * Update locale file * Removing redundant @mapbox/geojson-rewind dep pkg * Remove unused map feature title * Bring map map feature tooltips * Add missing mapillary map feature classes * Update translation file * Bing imagery - Ensure freshness * bingImagery strict n param. Fallback url tempalate to latest * minor revert catch log * some bing imagery docs comments * typo * Add aws_deploy npm action to build workflow (#229) * Add aws_deploy npm action to build workflow Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script. * Hopefully more verbose logging when amazon fails * DO NOT MERGE: Adding hook for this branch to test on github * Better capture failure cases of aws calls * Going with the middle spam level for logging * Replace Rollup with Esbuild. (#246) * Add new esbuild-based quickstart directive. * Get the esbuild legacy build working, save for issues with NSI. * Upgrade several dependencies, bump minimum node version to 12 - country-coder (closes #249) - location-conflation (closes #248) - osm-community-index (closes #250) - name-suggestion-index * Bump marked from 2.0.7 to 2.1.2 Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v2.0.7...v2.1.2) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Add the es5 directive back. * Get dev builds working once again, normal builds still slightly wonky. * Get some sort of legacy build working by converting requires() to import statements. * Fix target for esbuild legacy build * Move build all directive to use esbuild. * Add visualizer capability and build directive. * Remove rollup from dependency list completely! Co-authored-by: Bryan Housel <bhousel@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove special case for push to deploy_with_action This was just used during development * Clean up log, and add link to build result * One too many slashes * Is this simple conditional good enough? * Better syntax? * Now with correct syntax * Bump osm-community-index from 5.0.1 to 5.1.0 Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/osmlab/osm-community-index/releases) - [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md) - [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: osm-community-index dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump osm-community-index from 5.0.1 to 5.1.0 * If locationSet is missing `include`, default to worldwide include openstreetmap/iD#8305 (comment) * pacify eslint, fix merge goof in map.js * Build sourcemap too * Use pagination to fetch all the esri datasets (closes #257) * Bump object-inspect from 1.10.3 to 1.11.0 Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0. - [Release notes](https://github.com/inspect-js/object-inspect/releases) - [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: object-inspect dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * gitignore esbuild.json It changes on every build and is only use to rebuild the stats * Bump osm-community-index to 5.1.1 * Modernize more scripts (convert require to import) * npm run imagery * npm run translations * rapid-v1.1.5 * Set z-index of absolutely positioned layers under supersurface Each of these has their own internal stacking context * npm run translations * Fix link * Math/extent conversion (#272) * Bump version to newest id-sdk release. * Convert geoExtent to id-sdk/Extent. Most tests working. * Fix remaining tests. * Remove geo modules no longer in use. * Revert "Fix remaining tests." This reverts commit 7ba89ce. * Fix a number of instances of extents being used as raw tuples. * Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion. * Fix roads/ways not appearing in the map, also fix a crossing ways test problem. * Fix an issue with the measurement panel not setting its extent correctly. * fix usages of Extend.extend() because it no longer modifies the extent in-place. * Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity. * add service module for querying streetview suggestions (#192) * Show suggestion images and viewfield icon * fix PR comments * hightlight images and viewfields on hover * Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right. * Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly. * Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk. * Fix bug that was selecting the wrong service when we selected a sidewalk suggestion. * Get image strip working with Bryan's help. * Fix sorting of images by longitude. * Improve styling of the image strip, and add 'enlarge on mouse hover' interaction. * style suggested sidewalks * Parse crosswalk data * remove console.log statement * Fix debug messages that shouldn't have been checked in. * Fix issue that was causing too many viewfield nodes to appear. * fix hovering issues * Fix some linter errors. * Make 5 images not require a scrollbar in the image strip, even when one is zoomed. * Fix images to all have the same height, not the same width. * Fix code drift issues that had occurred in main. Co-authored-by: Milos Brzakovic (E-Search) <mbrzakovic@microsoft.com> Co-authored-by: Bryan Housel <bhousel@gmail.com> Co-authored-by: Nikola Pleša <nikolaplesa@fb.com> Co-authored-by: Milos Brzakovic <78906108+mbrzakovic@users.noreply.github.com> Co-authored-by: Danny Krause <vanreece@gmail.com> Co-authored-by: Ben Clark <bennyc@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Gao <mkobie@gmail.com> Co-authored-by: Amol Vasant Khadilkar <amolk@fb.com> Co-authored-by: Benjamin Clark <clarkben@fb.com>
Bonkles
added a commit
that referenced
this pull request
Oct 29, 2021
* Move CrossEditableZoom event firing. It should happen after projection is transformed. * Bump versions * Switch to Mapillary API v4 * Fix traffic sign rendering and geometry conversion * Remove debugging code * Update locale file * Removing redundant @mapbox/geojson-rewind dep pkg * Remove unused map feature title * Bring map map feature tooltips * Add missing mapillary map feature classes * Update translation file * Bing imagery - Ensure freshness * bingImagery strict n param. Fallback url tempalate to latest * minor revert catch log * some bing imagery docs comments * typo * Add aws_deploy npm action to build workflow (#229) * Add aws_deploy npm action to build workflow Added the scripts/aws_deploy.py script which will run at the end of github builds and push stuff up to s3, so that you can easily get builds to reviewers or anyone else without issue. Needs to have some secrets set up on github to work, documentation is at the top of the python script. * Hopefully more verbose logging when amazon fails * DO NOT MERGE: Adding hook for this branch to test on github * Better capture failure cases of aws calls * Going with the middle spam level for logging * Replace Rollup with Esbuild. (#246) * Add new esbuild-based quickstart directive. * Get the esbuild legacy build working, save for issues with NSI. * Upgrade several dependencies, bump minimum node version to 12 - country-coder (closes #249) - location-conflation (closes #248) - osm-community-index (closes #250) - name-suggestion-index * Bump marked from 2.0.7 to 2.1.2 Bumps [marked](https://github.com/markedjs/marked) from 2.0.7 to 2.1.2. - [Release notes](https://github.com/markedjs/marked/releases) - [Changelog](https://github.com/markedjs/marked/blob/master/release.config.js) - [Commits](markedjs/marked@v2.0.7...v2.1.2) --- updated-dependencies: - dependency-name: marked dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Add the es5 directive back. * Get dev builds working once again, normal builds still slightly wonky. * Get some sort of legacy build working by converting requires() to import statements. * Fix target for esbuild legacy build * Move build all directive to use esbuild. * Add visualizer capability and build directive. * Remove rollup from dependency list completely! Co-authored-by: Bryan Housel <bhousel@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Remove special case for push to deploy_with_action This was just used during development * Clean up log, and add link to build result * One too many slashes * Is this simple conditional good enough? * Better syntax? * Now with correct syntax * Bump osm-community-index from 5.0.1 to 5.1.0 Bumps [osm-community-index](https://github.com/osmlab/osm-community-index) from 5.0.1 to 5.1.0. - [Release notes](https://github.com/osmlab/osm-community-index/releases) - [Changelog](https://github.com/osmlab/osm-community-index/blob/main/CHANGELOG.md) - [Commits](osmlab/osm-community-index@v5.0.1...v5.1.0) --- updated-dependencies: - dependency-name: osm-community-index dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump osm-community-index from 5.0.1 to 5.1.0 * If locationSet is missing `include`, default to worldwide include openstreetmap/iD#8305 (comment) * pacify eslint, fix merge goof in map.js * Build sourcemap too * Use pagination to fetch all the esri datasets (closes #257) * Bump object-inspect from 1.10.3 to 1.11.0 Bumps [object-inspect](https://github.com/inspect-js/object-inspect) from 1.10.3 to 1.11.0. - [Release notes](https://github.com/inspect-js/object-inspect/releases) - [Commits](inspect-js/object-inspect@v1.10.3...v1.11.0) --- updated-dependencies: - dependency-name: object-inspect dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * gitignore esbuild.json It changes on every build and is only use to rebuild the stats * Bump osm-community-index to 5.1.1 * Modernize more scripts (convert require to import) * npm run imagery * npm run translations * rapid-v1.1.5 * Set z-index of absolutely positioned layers under supersurface Each of these has their own internal stacking context * npm run translations * Fix link * Math/extent conversion (#272) * Bump version to newest id-sdk release. * Convert geoExtent to id-sdk/Extent. Most tests working. * Fix remaining tests. * Remove geo modules no longer in use. * Revert "Fix remaining tests." This reverts commit 7ba89ce. * Fix a number of instances of extents being used as raw tuples. * Woops- converted zoom/pan functionality that interacts with d3. NOT a candidate for Extent() conversion. * Fix roads/ways not appearing in the map, also fix a crossing ways test problem. * Fix an issue with the measurement panel not setting its extent correctly. * fix usages of Extend.extend() because it no longer modifies the extent in-place. * Fix copy / paste bug that falsely claimed everything had an extent of +/- Infinity. * add service module for querying streetview suggestions (#192) * Show suggestion images and viewfield icon * fix PR comments * hightlight images and viewfields on hover * Sort images by increasing longitude, so that the left-rightness of images matches the flow of the map points as we scan left->right. * Add image strip as separate component (still quite buggy). Fix the two-way binding between image fields and images in the strip so that hover/select highlights correctly. * Fix the image filmstrip so that it is properly shut off / redisplayed as the user hovers over / moves off a sidewalk. * Fix bug that was selecting the wrong service when we selected a sidewalk suggestion. * Get image strip working with Bryan's help. * Fix sorting of images by longitude. * Improve styling of the image strip, and add 'enlarge on mouse hover' interaction. * style suggested sidewalks * Parse crosswalk data * remove console.log statement * Fix debug messages that shouldn't have been checked in. * Fix issue that was causing too many viewfield nodes to appear. * fix hovering issues * Fix some linter errors. * Make 5 images not require a scrollbar in the image strip, even when one is zoomed. * Fix images to all have the same height, not the same width. * Fix code drift issues that had occurred in main. Co-authored-by: Milos Brzakovic (E-Search) <mbrzakovic@microsoft.com> Co-authored-by: Bryan Housel <bhousel@gmail.com> Co-authored-by: Nikola Pleša <nikolaplesa@fb.com> Co-authored-by: Milos Brzakovic <78906108+mbrzakovic@users.noreply.github.com> Co-authored-by: Danny Krause <vanreece@gmail.com> Co-authored-by: Ben Clark <bennyc@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Xiaoming Gao <mkobie@gmail.com> Co-authored-by: Amol Vasant Khadilkar <amolk@fb.com> Co-authored-by: Benjamin Clark <clarkben@fb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts all the math/extent code in RapiD to consume the id-sdk.
I have started with just the
math/extentlibrary, but can open additional PRs / extend this PR to do a total conversion if folks want!Screenshot of working tests:
Screenshot of (ruh roh) OSM Ways not displaying. Need to drill down into why this is happening: