added solution for running Laravel Dusk in production #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR - can you also add a test to verify that the given exception returns those two solutions? |
|
@mpociot good one, forgot those. Will add them |
Signed-off-by: Tonko Mulder <tonko@tonkomulder.nl>
Signed-off-by: Tonko Mulder <t.mulder@jvdmedia.nl>
Treggats
force-pushed
the
add_not_safe_to_run_dusk_in_production_solution
branch
from
3a893a4
to
f71ba5d
Compare
|
@mpociot done, added test which asserts the two solutions |
freekmurze
approved these changes
Sep 18, 2019
|
Great job! Thank you |
Treggats
deleted the
add_not_safe_to_run_dusk_in_production_solution
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in issue #71
This PR provides two solutions for when Laravel Dusk is running in production.
--no-devflagAPP_ENVvalue