Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatternBrush.source on Ipad #3043

Closed
Rad1calDreamer opened this issue Jun 10, 2016 · 8 comments · Fixed by #3112
Closed

PatternBrush.source on Ipad #3043

Rad1calDreamer opened this issue Jun 10, 2016 · 8 comments · Fixed by #3112

Comments

@Rad1calDreamer
Copy link

Version

1.6.2

When i use PatternBrush with imageHtml as source on ipad - pattern more than img. Like 4k scale.
But if i create fabric.Image from this imageHtml -> all ok. Its only on ipad. On Windows PC - all ok

@butch2k
Copy link

butch2k commented Jun 10, 2016

It's the same issue as this one: #3041
desactivate retina support in fabric and it will work nicely.

@jhiswin
Copy link

jhiswin commented Jun 12, 2016

Interesting that it works okay when you create fabric.Image. I still have issues even after wrapping in an Image.
Can you post a simplified jsfiddle? It'll also save me the trouble of creating a simplified test case :p

It seems like the issue may be with using the source element rather than the actual fabric.Image class?

@Rad1calDreamer
Copy link
Author

i reproduce my code, but cant now check on Ipad
http://jsfiddle.net/u2g3zgxq/10/

@jhiswin
Copy link

jhiswin commented Jun 14, 2016

@Rad1calDreamer Just a quick tip for you: in Chrome Dev tools you can emulate a device (used to be Emulate screen), which will let you see how retina would look.

@Rad1calDreamer
Copy link
Author

ofc i know it.
I think we need some pattern's settings like "repeat" and "size (aka background size)"

@asturur
Copy link
Member

asturur commented Jun 14, 2016

i'll take care of this ticket as soon as i can release 1.6.3
I'm spending lot of time on retina screens lately to fix lot of issues.

@asturur
Copy link
Member

asturur commented Jun 14, 2016

oh you know your demo is super inspiring for fixing: #851

@Rad1calDreamer
Copy link
Author

hi, it's still reproduce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants