Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add nox task to verify dependency declarations #233

Open
2 tasks
ckunki opened this issue Aug 9, 2024 · 1 comment · May be fixed by #236
Open
2 tasks

✨ Add nox task to verify dependency declarations #233

ckunki opened this issue Aug 9, 2024 · 1 comment · May be fixed by #236
Assignees
@Jannis-Mittenzwei
Labels
feature Product feature

Comments

@ckunki
Copy link
Contributor

ckunki commented Aug 9, 2024 •
edited
Loading

Summary

pyproject.toml support different alternatives for declaring dependencies to other python packages:

  • reference to a release published on pypi
  • reference to a path in the local file system
  • reference to a GitHub repository, optionally including a branch or commit SHA1

Details

The PTB should be enhanced

  • to detect other references other than those to releases published on pypi
  • avoid merging to the main branch

Background & Context

The Exasol Integration Team decided to only use references to releases published on pypi.
Other references turned out to cause inconsistencies in dependencies and a lot of trouble.

Tasks

  • add nox task
  • enhance templates for GitHub workflows
@ckunki ckunki added the feature Product feature label Aug 9, 2024
@Jannis-Mittenzwei Jannis-Mittenzwei linked a pull request Aug 20, 2024 that will close this issue
Open
@Jannis-Mittenzwei Jannis-Mittenzwei self-assigned this Aug 21, 2024
@Jannis-Mittenzwei
Copy link
Contributor

waiting for review by @Nicoretti

Jannis-Mittenzwei added a commit that referenced this issue Sep 3, 2024
@Jannis-Mittenzwei
Merge branch 'main' into feature/#233-add-nox-task-to-verify-dependen…
9c33b61 
…cy-declarations
Jannis-Mittenzwei added a commit that referenced this issue Sep 3, 2024
@Jannis-Mittenzwei
Merge remote-tracking branch 'origin/feature/#233-add-nox-task-to-ver…
b7c04a8 
…ify-dependency-declarations' into feature/#233-add-nox-task-to-verify-dependency-declarations

# Conflicts:
#	exasol/toolbox/nox/_dependencies_check.py
Jannis-Mittenzwei added a commit that referenced this issue Sep 10, 2024
@Jannis-Mittenzwei
Merge remote-tracking branch 'origin/feature/#233-add-nox-task-to-ver…
e03b093 
…ify-dependency-declarations' into feature/#233-add-nox-task-to-verify-dependency-declarations

# Conflicts:
#	.github/workflows/report.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jannis-Mittenzwei Jannis-Mittenzwei

Labels
feature Product feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add nox task to verify dependency declarations exasol/python-toolbox
2 participants
@ckunki @Jannis-Mittenzwei