Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

keep balance when override account #353

Merged
merged 1 commit into from
Jul 26, 2021
Merged

Conversation

yihuang
Copy link
Contributor

@yihuang yihuang commented Jul 26, 2021

Closes: #342

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #353 (20ecd70) into main (30cc004) will increase coverage by 15.60%.
The diff coverage is n/a.

❗ Current head 20ecd70 differs from pull request most recent head a610e8f. Consider uploading reports for the commit a610e8f to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #353       +/-   ##
===========================================
+ Coverage   52.42%   68.03%   +15.60%     
===========================================
  Files          46        9       -37     
  Lines        4614     1198     -3416     
===========================================
- Hits         2419      815     -1604     
+ Misses       2093      358     -1735     
+ Partials      102       25       -77     
Impacted Files Coverage Δ
x/evm/keeper/params.go
x/evm/keeper/abci.go
types/account.go
x/evm/types/codec.go
x/evm/types/query.pb.gw.go
x/evm/types/chain_config.go
types/config.go
x/evm/types/storage.go
x/evm/types/logs.go
types/codec.go
... and 26 more

@yihuang
Copy link
Contributor Author

yihuang commented Jul 26, 2021

Copy link
Contributor

@leejw51crypto leejw51crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

CHANGELOG.md Outdated Show resolved Hide resolved
@fedekunze fedekunze enabled auto-merge (squash) July 26, 2021 07:39
@fedekunze fedekunze merged commit 2828fa1 into evmos:main Jul 26, 2021
@yihuang yihuang deleted the account-override branch July 26, 2021 08:16
yihuang referenced this pull request in yihuang/ethermint Sep 21, 2023
* Problem: blocked address feature is not generic

Solution:
- remove the direct support
- support providing extra decorators instead

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* fix

---------

Signed-off-by: yihuang <huang@crypto.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateAccount don't transfer balance from old account
3 participants