Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

deps: bump geth to 1.10.20 #1451

Closed
wants to merge 6 commits into from
Closed

deps: bump geth to 1.10.20 #1451

wants to merge 6 commits into from

Conversation

VictorTrustyDev
Copy link
Contributor

@VictorTrustyDev VictorTrustyDev commented Nov 10, 2022

Ref: #1254
not able to go direct 1.10.25 because 1.10.21 & 1.10.22 contains RPC APIs changes, should be done in separated PRs (I think so)

Description

Updated RPC APIs within scope of Geth v1.10.20

Resolved by d9e17a7 and 57bfdaa

Resolved by 0739ad7 <<< it's contains bug (copied originally)
So I plus cb6919b which copy the code that fixes the above bug in geth 1.10.21 by #25244

Ethermint not yet implemented this endpoint

Consensus area, Ethermint not use this

Not relates to ethermint???


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@VictorTrustyDev VictorTrustyDev marked this pull request as ready for review November 10, 2022 19:07
@VictorTrustyDev VictorTrustyDev requested a review from a team as a code owner November 10, 2022 19:07
@VictorTrustyDev VictorTrustyDev requested review from 0a1c and ramacarlucho and removed request for a team November 10, 2022 19:07
@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1451 (cb6919b) into main (4837b8b) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1451      +/-   ##
==========================================
+ Coverage   59.93%   59.96%   +0.02%     
==========================================
  Files         109      109              
  Lines       10259    10254       -5     
==========================================
  Hits         6149     6149              
+ Misses       3839     3834       -5     
  Partials      271      271              
Impacted Files Coverage Δ
rpc/backend/backend.go 46.66% <ø> (ø)
rpc/backend/chain_info.go 10.55% <0.00%> (+0.49%) ⬆️
rpc/backend/tx_info.go 0.00% <0.00%> (ø)
rpc/types/utils.go 0.00% <0.00%> (ø)

@facs95
Copy link
Contributor

facs95 commented Nov 11, 2022

Hey @VictorTrustyDev! Thanks for dealing with this. But this is already being worked on #1413 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants