Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

sdk v0.45.8, tendermint v0.34.21, iavl v0.19.1 & store options #1301

Merged
merged 5 commits into from
Aug 29, 2022

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Aug 25, 2022

Description

Evmos v8.0.x is slated to use sdk v0.45.7 and ibc-go v3.2.0 and both of these enable the iavl fast cache features.

Currently ethermint did not have these and this was causing:

evmos/evmos#868

This patch bumps ethermint's release/v0.19.x branch to:

  • cosmos-sdk v0.45.8
  • tendermint v0.34.21
  • iavl v0.19.1

Mixing fast-cache enabled libraries and non-fast-cache enabled libraries seems not to go well.

Suggested way forward

  • merge this
  • cut an ethermint v0.19.1
  • We'll take the draft PR I'm making for evmos now, and get rid of the replace statement that I'm using to test the work.

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@@ -292,7 +292,10 @@ func (c TLSConfig) Validate() error {

// GetConfig returns a fully parsed Config object.
func GetConfig(v *viper.Viper) Config {
cfg := config.GetConfig(v)
cfg, err := config.GetConfig(v)
Copy link
Contributor Author

@faddat faddat Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the error check here. There could be a better way to do this like either making the whole function return an error, or just using a blank in place of err.

Copy link
Contributor

@facs95 facs95 Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to return the error instead

@faddat faddat mentioned this pull request Aug 25, 2022
12 tasks
@codecov
Copy link

codecov bot commented Aug 28, 2022

Codecov Report

Merging #1301 (8cbd658) into release/v0.19.x (0b1a3ae) will decrease coverage by 0.04%.
The diff coverage is 7.14%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           release/v0.19.x    #1301      +/-   ##
===================================================
- Coverage            51.20%   51.16%   -0.05%     
===================================================
  Files                  103      103              
  Lines                 9352     9358       +6     
===================================================
- Hits                  4789     4788       -1     
- Misses                4304     4310       +6     
- Partials               259      260       +1     
Impacted Files Coverage Δ
rpc/backend/node_info.go 0.00% <0.00%> (ø)
server/config/config.go 22.22% <0.00%> (-0.27%) ⬇️
rpc/backend/backend.go 48.27% <33.33%> (-5.30%) ⬇️

Copy link
Contributor

@facs95 facs95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -292,7 +292,10 @@ func (c TLSConfig) Validate() error {

// GetConfig returns a fully parsed Config object.
func GetConfig(v *viper.Viper) Config {
cfg := config.GetConfig(v)
cfg, err := config.GetConfig(v)
Copy link
Contributor

@facs95 facs95 Aug 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to return the error instead

Copy link
Contributor

@danburck danburck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@faddat can you add a changelog?

@danburck danburck enabled auto-merge (squash) August 29, 2022 15:42
@danburck
Copy link
Contributor

Run Gosec is failing. This is failing on other PRs too and seems to be unrelated to this PR => merging

@danburck danburck disabled auto-merge August 29, 2022 16:17
@danburck danburck merged commit 1d2cac9 into evmos:release/v0.19.x Aug 29, 2022
@facs95 facs95 deleted the store-options branch August 29, 2022 16:31
@faddat
Copy link
Contributor Author

faddat commented Aug 29, 2022

@danburck I think it is because I am making pr's from an external repo

devon-chain pushed a commit to PundiAI/ethermint that referenced this pull request Nov 17, 2022
…#1301)

* sdk v0.45.8, tendermint v0.34.21, iavl v0.19.1 & store options

* update gomod2nix

* return error instead of panic

* add Changelog

Co-authored-by: Freddy Caceres <facs95@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants